Thanks, Rousseau. Yes, it's a typo and should be fixed.
Reviewed-by: Feng Tian <[email protected]> PS: I didn't see your first mail, that's why we have no response to you. Where did you post it to? Thanks Feng -----Original Message----- From: Ludovic Rousseau [mailto:[email protected]] Sent: Saturday, May 23, 2015 18:13 To: [email protected] Subject: Re: [edk2] [PATCH] MdePkg: fix compilation error Hello, I got no feedback about my simple patch fixing a real probkem in Include/Protocol/SmartCardReader.h. What am I supposed to do? Just wait for someone to review the patch and push it? The patch is also available at https://github.com/LudovicRousseau/edk2/commit/4536658c02a6e53c58d82ba0d46338c8b67019cd Regards, 2015-05-19 22:17 GMT+02:00 Ludovic Rousseau <[email protected]>: > Remove an extra parenthesis in Include/Protocol/SmartCardReader.h > > Compilation error was: > MdePkg/Include/Protocol/SmartCardReader.h:219:3: error: expected identifier > or ‘(’ before ‘)’ token > ); > ^ > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ludovic Rousseau <[email protected]> > --- > MdePkg/Include/Protocol/SmartCardReader.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MdePkg/Include/Protocol/SmartCardReader.h > b/MdePkg/Include/Protocol/SmartCardReader.h > index d6e1887..a9a9cf2 100644 > --- a/MdePkg/Include/Protocol/SmartCardReader.h > +++ b/MdePkg/Include/Protocol/SmartCardReader.h > @@ -215,7 +215,6 @@ EFI_STATUS > IN UINTN CAPDULength, > OUT UINT8 *RAPDU, > IN OUT UINTN *RAPDULength > -); > ); > > /** > -- > 2.4.0 > -- Dr. Ludovic Rousseau ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
