On 05/28/15 19:53, Laszlo Ersek wrote: > On 05/28/15 18:51, Laszlo Ersek wrote: >> From: Olivier Martin <[email protected]> >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Olivier Martin <[email protected]> >> Cc: Olivier Martin <[email protected]> >> Cc: Ard Biesheuvel <[email protected]> >> [[email protected]: no changes other than adding Cc's] >> Signed-off-by: Laszlo Ersek <[email protected]> >> >> Signed-off-by: Laszlo Ersek <[email protected]> >> --- > > Okay, so I'm reviewing this because I reposted Olivier's patch without > any changes (modulo the different formatting requested from > git-format-patch).
[snip] > The patch looks good. Let me see if it builds: > > - ArmVirtXen: builds (I didn't run it) > - ArmVirtQemu: builds (I didn't run it) > - ArmVirtQemu, with -D INTEL_BDS: builds, and runs too > > Reviewed-by: Laszlo Ersek <[email protected]> > Tested-by: Laszlo Ersek <[email protected]> The above tags remain in effect, but I have a suggestion for an *additional* patch (of course with Ard we can do that ourselves as well): I think the following two files should be *copied* into the new ArmVirtPkg/ directory: - ArmPlatformPkg/Contributions.txt - ArmPlatformPkg/License.txt Because no top-level directory should exist without them. Again, no need to resubmit this series (it can be applied already, since we've satisfied the review criteria set forth in the blurb). A 3/2 patch could be tacked on, or even posted separately. Thanks, Laszlo ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
