On 06/03/15 18:14, Ard Biesheuvel wrote:
> Thanks, pushed as r17554
Congrats to your first (am I right?) SVN commit!
A small tip (feel free to ignore it): since for edk2 patches, the
tianocore contribution agreement is needed, it's useful to set up a
commit message template. Something like:
[commit]
template = /home/ardb/misc/tianocore.template
where the referenced file would say:
--------------
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <[email protected]>
-----------------
The "trick" I'm proposing here is that you include your S-o-b with the
template as well, since you "should" have a template anyway. (Or else,
pass --signoff to "git-commit".)
Additionally, ask git-format-patch not to generate your S-o-b's on the fly:
[format]
signoff = false
Your posted patches will look the same, but the difference will be that
your commit messages themselves will include your signoffs; the S-o-b
tags won't be generated *only* when formatting the patches.
Why is this good? Because the resultant signoffs-in-commits will be
consistent with patches that you apply from others (with git-am), and
because this way you can add my R-b tag *after* your S-o-b, via rebasing.
Just my two cents (in a wall of text, sorry), feel free to ignore.
Thanks
Laszlo
------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
