On 06/06/15 03:30, Gabriel L. Somlo wrote: > On Sat, Jun 06, 2015 at 01:47:40AM +0200, Laszlo Ersek wrote: >> The first 9 patches are uninteresting (although they certainly decimated >> my grey matter): >> >> - Patch #1 copies PciHostBridgeDxe from PcAtChipsetPkg to OvmfPkg. I >> paid attention and passed the --find-copies-harder option to >> git-format-patch, hence reviewers should be able to spot the minimal >> differences easily. >> >> - Patches #2 to #9 reformat the copied driver's source code so that it >> is actually possible to work with it. Trailing whitespace is stripped, >> overlong lines are rewrapped to 79 characters. This was suprisingly >> difficult because the original code consistently uses 130-148 columns. >> >> Rather than dump the reformatting into one huge patch, I broke it up >> in order to help reviewers, generally keeping comment reformatting >> separate from code reformatting. These patches are responsible for the >> bulk of the diffstat. >> >> This half of the series would actually apply to >> PcAtChipsetPkg/PciHostBridgeDxe itself, and it would be possible to >> clone the driver for OvmfPkg only at the end of the first half. >> >> The other half of the series is more interesting: >> >> - Patches #10 to #12 tweak PlatformBdsLib in preparation for multiple >> root buses. For these: >> >> Cc: Gabriel Somlo <so...@cmu.edu> > > Patches #10 and #11: > Acked-by: Gabriel Somlo <so...@cmu.edu>
Thanks! I'll add these when committing the series or posting a v2. > Entire series: > Tested-by: Gabriel Somlo <so...@cmu.edu> > (with OOT sata patches, on pc and q35 machine types, with yosemite and > Fedora 21 live, boots and runs same as before, no additional/specific > torture tests). Did you add / exercise extra root buses (ie. did you use the new QEMU PXB feature)? If not, I'd prefer to add your Regression-tested-by. Is that okay with you? Many thanks Laszlo ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
