On 9 June 2015 at 04:10, Star Zeng <[email protected]> wrote:
> Call UnregisterSmramProfileImage() before image buffer freed.
>
> Cc: Jiewen Yao <[email protected]>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng <[email protected]>
> ---
> EdkCompatibilityPkg/Compatibility/SmmBaseHelper/SmmBaseHelper.c | 5
> ++---
> EdkCompatibilityPkg/Compatibility/SmmBaseHelper/SmramProfileRecord.c | 3 ++-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/EdkCompatibilityPkg/Compatibility/SmmBaseHelper/SmmBaseHelper.c
> b/EdkCompatibilityPkg/Compatibility/SmmBaseHelper/SmmBaseHelper.c
> index 2b94e4d..1d16449 100644
> --- a/EdkCompatibilityPkg/Compatibility/SmmBaseHelper/SmmBaseHelper.c
> +++ b/EdkCompatibilityPkg/Compatibility/SmmBaseHelper/SmmBaseHelper.c
> @@ -11,7 +11,7 @@
>
> SmmHandlerEntry() will receive untrusted input and do validation.
>
> - Copyright (c) 2009 - 2013, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD
> License
> which accompanies this distribution. The full text of the license may be
> found at
> @@ -34,7 +34,6 @@
> #include <Library/MemoryAllocationLib.h>
> #include <Library/SynchronizationLib.h>
> #include <Library/CpuLib.h>
> -#include <Library/PcdLib.h>
What is this change for? It is not mentioned in the commit log.
> #include <Guid/SmmBaseThunkCommunication.h>
> #include <Protocol/SmmBaseHelperReady.h>
> #include <Protocol/SmmCpu.h>
> @@ -734,10 +733,10 @@ LoadImage (
> RegisterSmramProfileImage (FilePath, DstBuffer, PageCount);
> Status = gBS->StartImage (*ImageHandle, NULL, NULL);
> if (EFI_ERROR (Status)) {
> + UnregisterSmramProfileImage (FilePath, DstBuffer, PageCount);
> mLoadPe32Image->UnLoadPeImage (mLoadPe32Image, *ImageHandle);
> *ImageHandle = NULL;
> FreePages ((VOID *)(UINTN)DstBuffer, PageCount);
> - UnregisterSmramProfileImage (FilePath, DstBuffer, PageCount);
> }
> }
>
> diff --git
> a/EdkCompatibilityPkg/Compatibility/SmmBaseHelper/SmramProfileRecord.c
> b/EdkCompatibilityPkg/Compatibility/SmmBaseHelper/SmramProfileRecord.c
> index 84eba48..a1797ea 100644
> --- a/EdkCompatibilityPkg/Compatibility/SmmBaseHelper/SmramProfileRecord.c
> +++ b/EdkCompatibilityPkg/Compatibility/SmmBaseHelper/SmramProfileRecord.c
> @@ -1,6 +1,6 @@
> /** @file
>
> - Copyright (c) 2014, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2014 - 2015, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD
> License
> which accompanies this distribution. The full text of the license may be
> found at
> @@ -20,6 +20,7 @@
> #include <Library/DevicePathLib.h>
> #include <Library/BaseMemoryLib.h>
> #include <Library/DebugLib.h>
> +#include <Library/PcdLib.h>
And this one?
> #include <Protocol/SmmCommunication.h>
>
> #include <Guid/MemoryProfile.h>
> --
> 1.9.5.msysgit.0
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
