On 16 June 2015 at 16:23, Laszlo Ersek <ler...@redhat.com> wrote:
> On 06/16/15 11:44, Ard Biesheuvel wrote:
>> This is a followup to r17554 ("ArmVirtPkg: increase memory
>> preallocations to reduce region count") that increases the sizes
>> of the preallocated regions to account for the footprint of the
>> crypto and authentication libraries. This is only done if secure
>> boot is enabled at build time, to prevent imposing a larger minimum
>> RAM size on non-secure builds.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
>> ---
>>  ArmVirtPkg/ArmVirt.dsc.inc | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
>> index 9c737712d45f..c6e684fd8512 100644
>> --- a/ArmVirtPkg/ArmVirt.dsc.inc
>> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
>> @@ -329,9 +329,15 @@ [PcdsFixedAtBuild.common]
>>    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0
>>    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS|0
>>    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType|0
>> +!if $(SECURE_BOOT_ENABLE) == TRUE
>> +  gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData|600
>> +  gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode|400
>> +  gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiBootServicesCode|1500
>> +!else
>>    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData|300
>>    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode|150
>>    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiBootServicesCode|1000
>> +!endif
>>    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiBootServicesData|20000
>>    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiLoaderCode|20
>>    gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiLoaderData|0
>>
>
> Reviewed-by: Laszlo Ersek <ler...@redhat.com>
>

Thanks guys. Committed as r17646

-- 
Ard.


> We should do something similar in OVMF as well -- the UEFI memmap looks
> quite fragmented as dumped by the Linux guest -- but alas I'll have no
> bandwidth for that in the near future I think.
>
> Thanks
> Laszlo

------------------------------------------------------------------------------
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to