Yes, the patch is taken from source code that has been tested on x86 with EDK1. ________________________________________ From: Leekha Shaveta [shav...@freescale.com] Sent: 18 June 2015 05:09 To: Olivier Martin; Laszlo Ersek Cc: edk2-devel@lists.sourceforge.net; Andrew Fish; Ruchika Gupta Subject: RE: [edk2] Query UEFI : PCIE Driver for Armv8 platform
Thanks for the patch Olivier! As you said that this patch is not tested, is it taken from some tested reference? As it’s a huge untested patch :) Regards, Shaveta -----Original Message----- From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Wednesday, June 17, 2015 9:51 PM To: Laszlo Ersek Cc: edk2-devel@lists.sourceforge.net; Leekha Shaveta-B20052; Andrew Fish; Gupta Ruchika-R66431 Subject: RE: [edk2] Query UEFI : PCIE Driver for Armv8 platform Ahah, I knew this hidden link would make some people happy! Hmm, I think the driver was on one of my old hard disk. I have just tried to see if I can redo the work again. It took me a couple of hours :-/ Anyway, I sent the patch. It builds with GCC49. But as I said I have not tested it. -----Original Message----- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: 16 June 2015 20:01 To: Olivier Martin Cc: edk2-devel@lists.sourceforge.net; Leekha Shaveta; Andrew Fish; Ruchika Gupta Subject: Re: [edk2] Query UEFI : PCIE Driver for Armv8 platform On 06/16/15 20:01, Olivier Martin wrote: > Sources for the E1000 EFI driver exists.... > The sources are for EDK1. They can be downloaded here: > http://tianocore.sourceforge.net/wiki/EDK > > I think I had ported this driver to EDK2 in the past for fun - I did > not have the opportunity to test it. I do not remember to have any > difficulties to port it. Very interesting! I wonder then why the PROEFI driver is now proprietary and wrapped into a draconian license. (It's not even redistributable in intact binary form IIRC.) Do you have your edk2 port of the edk1 E1000 driver still around? That would be a great addition to OVMF: at the moment we have a builtin virtio-net driver, but for Windows guests, the emulated E1000 NIC seems to be the default choice. (For example, the virtio-win driver ISO is then not needed during guest installation, because Windows has a builtin E1000 driver.) iPXE does have a UEFI driver oprom for the E1000, but (a) sometimes you don't want to use iPXE, (b) for ARM virtual machines, iPXE is not available. QEMU already provides PCIe emulation for the "virt" machine type, and ArmVirtPkg knows how to use it, so -- thinking of (upcoming?) Windows-on-ARM guests -- an open source E1000 driver that builds as part of ArmVirtPkg would be very cool. Summary: - OvmfPkg could PXE-boot off E1000 without iPXE - ArmVirtPkg could PXE-boot off E1000 (as only E1000 option) - some users prefer E1000 in VMs that run Windows Thanks Laszlo > > > -----Original Message----- > From: Leekha Shaveta [mailto:shav...@freescale.com] > Sent: 08 June 2015 07:59 > To: Andrew Fish; edk2-devel@lists.sourceforge.net > Cc: Olivier Martin; Ruchika Gupta > Subject: RE: [edk2] Query UEFI : PCIE Driver for Armv8 platform > > Thanks Andrew! > > Is there some PCI NIC card or E1000 driver (PCI device driver) written on top > of PCI bus driver, any references? > > One is Intel's e1000 driver, which is proprietary and is requested by the -D > E1000_ENABLE build flag. > > I have seen in logs that some libraries are referred like: > > NetLib|MdeModulePkg/Library/DxeNetLib/ > IpIoLib|MdeModulePkg/Library/DxeIpIoLib/ > UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/ > DpcLib|MdeModulePkg/Library/DxeDpcLib/ > > > Are these required for PCI NIC driver? > > Thanks and regards, > Shaveta > > -----Original Message----- > From: Andrew Fish [mailto:af...@apple.com] > Sent: Friday, June 05, 2015 10:50 PM > To: Leekha Shaveta-B20052 > Cc: edk2-devel@lists.sourceforge.net; olivier.mar...@arm.com > Subject: Re: [edk2] Query UEFI : PCIE Driver for Armv8 platform > > >> On Jun 5, 2015, at 4:23 AM, Leekha Shaveta <shav...@freescale.com> wrote: >> >> Thanks Andrew! >> >> Few more Doubts : >> How ACPI is defining PCI resources? >> What are these PCI resources and their functions? Are these resources >> are like some regions in "PCI Express space” > > Leekha you need to think about it from the hardware point of view…. > > The PCI root bridge sits on the CPU bus and it produces PCI. So that PCI root > bridge has to be configured to forward transactions. > From the firmware point of view you are configuring the chip to decode memory > addresses and resources to forward them to PCI. > From an OS (or generic PCI bus driver) you are defining the resource pool > that is available to config PCI devices. So assign bus numbers, and populate > BARs. > >> ? >> > >> As I was referring ArmJunoPkg for PCI Host Bridge implementation. And found >> this ACPI configuration used: >>> >>> RESOURCE_CONFIGURATION Configuration = { >>> {{ACPI_ADDRESS_SPACE_DESCRIPTOR, 0x2B, ACPI_ADDRESS_SPACE_TYPE_IO , 0, 0, >>> 0, 0, 0, 0, 0}, >>> {ACPI_ADDRESS_SPACE_DESCRIPTOR, 0x2B, ACPI_ADDRESS_SPACE_TYPE_MEM, 0, 0, >>> 32, 0, 0, 0, 0}, >>> {ACPI_ADDRESS_SPACE_DESCRIPTOR, 0x2B, ACPI_ADDRESS_SPACE_TYPE_MEM, 0, 6, >>> 32, 0, 0, 0, 0}, >>> {ACPI_ADDRESS_SPACE_DESCRIPTOR, 0x2B, ACPI_ADDRESS_SPACE_TYPE_MEM, 0, 0, >>> 64, 0, 0, 0, 0}, >>> {ACPI_ADDRESS_SPACE_DESCRIPTOR, 0x2B, ACPI_ADDRESS_SPACE_TYPE_MEM, 0, 6, >>> 64, 0, 0, 0, 0}, >>> {ACPI_ADDRESS_SPACE_DESCRIPTOR, 0x2B, ACPI_ADDRESS_SPACE_TYPE_BUS, 0, 0, >>> 0, 0, 255, 0, 255}}, >>> {ACPI_END_TAG_DESCRIPTOR, 0} >>> }; >>> >>> Hi Olivier, >>> Can you please help in understanding this resource configuration ? >>> Here you seem to be specifying one IO, 4 Mem and 1 Bus space. Why 6 of them >>> and how do they differ? >> >> On which basis 6 resources are given here? >> > > These are the basic resource types supported by PCI. > > I/O so the inb outb instructions on X86 (IO BAR) 32-bit Prefetch and > non-Prefetch memory (Memory BAR) 64-bit Prefetch and non-Prefetch > memory (Memory BAR) PCI Bus numbers. (Bus Number) > > Thanks, > > Andrew Fish > >> Thanks and Regards, >> Shaveta >> > > -- IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > > ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, > Registered in England & Wales, Company No: 2557590 ARM Holdings plc, > Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in > England & Wales, Company No: 2548782 > ---------------------------------------------------------------------- > -------- _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782 -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782 ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
