Hi Eric, I had a lot of trouble with intrinsics (although now both GCC49 and VS2013 work for me). When compiling the regex library, MSVC inserts calls to intrinsics where no function call exists. /Oi- didn't fix this, so I decided to redefine memcpy/set by copying definitions from CryptoPkg/IntrinsicLib. I can't reproduce your error, but do you have a suggestion for how to fix this? I don't understand what MSVC is doing.
________________________________________ From: Dong, Eric [eric.d...@intel.com] Sent: Friday, June 19, 2015 02:55 To: Tian, Feng; edk2-devel@lists.sourceforge.net; Doman, Jonathan Subject: RE: [PATCH v3] MdeModulePkg: Regular expression protocol Jonathan, I merged the code and build with VS2013(build -t VS2013x86 -p MdeModulePkg\MdeModulePkg.dsc -a X64), but it failed with below error message, can you help to fix the build errors? Finished generating code RegularExpressionDxe.lib(unicode.obj) : fatal error LNK1237: during code generation, compiler introduced reference to symbol memcpy defined in module 'RegularExpressionDxe.lib(OnigurumaIntrinsics.obj)' compiled with /GL NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 12.0\Vc\bin\x86_amd64\link.exe"' : return code '0x4d5' Stop. Thanks, Eric -----Original Message----- From: Tian, Feng Sent: Friday, June 19, 2015 9:55 AM To: edk2-devel@lists.sourceforge.net; jonathan.do...@hp.com; Dong, Eric Cc: Tian, Feng Subject: RE: [PATCH v3] MdeModulePkg: Regular expression protocol Thanks for your contribution, Jonathan. Eric would review this patch and get back to you if he has feedback Thanks Feng -----Original Message----- From: Doman, Jonathan [mailto:jonathan.do...@hp.com] Sent: Friday, June 19, 2015 02:23 To: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH v3] MdeModulePkg: Regular expression protocol Patch is hosted on github here: https://github.com/jrmrjnck/edk2/commit/b186f03121679b44cc224d7c69f04f9b4b799bc3.patch Unfortunately, the patch is too large and gets stuck in the edk2-devel mod queue. The bulk of it is a new regular expression library, so it doesn't make sense to split up. Please let me know if there is a preferred way to submit large patches. Add driver to produce EFI_REGULAR_EXPRESSION_PROTOCOL. Based on Oniguruma v5.9.6 (BSD 2-clause license), which provides full Unicode support, and POSIX ERE and Perl regex syntaxes. --- v3 changes: * Put regex library directly under driver and forget about driver/library de-coupling. * Switch from SLRE to Oniguruma implementation, which is much more robust and useful. ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel