Reviewed-by: Liming Gao <liming....@intel.com> -----Original Message----- From: Yingke Liu [mailto:yingke.d....@intel.com] Sent: Friday, June 19, 2015 1:27 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch] BaseTools: Build report should not be generated if build failed.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yingke Liu <yingke.d....@intel.com> --- BaseTools/Source/Python/build/build.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py index 9b48ac0..33b45ba 100644 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -1965,6 +1965,7 @@ def Main(): EdkLogger.quiet(time.strftime("Build start time: %H:%M:%S, %b.%d %Y\n", time.localtime())); ReturnCode = 0 MyBuild = None + BuildError = True try: if len(Target) == 0: Target = "all" @@ -2035,6 +2036,10 @@ def Main(): SqlCommand = """drop table IF EXISTS %s""" % TmpTableName TmpTableDict[TmpTableName].execute(SqlCommand) #MyBuild.DumpBuildData() + # + # All job done, no error found and no exception raised + # + BuildError = False except FatalError, X: if MyBuild != None: # for multi-thread build exits safely @@ -2095,7 +2100,8 @@ def Main(): else: BuildDurationStr = time.strftime("%H:%M:%S", BuildDuration) if MyBuild != None: - MyBuild.BuildReport.GenerateReport(BuildDurationStr) + if not BuildError: + MyBuild.BuildReport.GenerateReport(BuildDurationStr) MyBuild.Db.Close() EdkLogger.SetLevel(EdkLogger.QUIET) EdkLogger.quiet("\n- %s -" % Conclusion) -- 1.9.5.msysgit.0 ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Monitor 25 network devices or servers for free with OpManager! OpManager is web-based network management software that monitors network devices and physical & virtual servers, alerts via email & sms for fault. Monitor 25 devices for free with no restriction. Download now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel