MdeModulePkg has defined gZeroGuid in 'Guid/ZeroGuid.h', therefore, the
gZeroGuid defined in DataHubDxe is redundant.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a...@intel.com>
Reviewed-by: Liming Gao <liming....@intel.com>
Reviewed-by: Jaben Carsey <jaben.car...@intel.com>
---
IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c | 4 +---
IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h | 4 +++-
IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf | 7 ++++++-
3 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c
b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c
index 01bc215..91f7c7e 100644
--- a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c
+++ b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.c
@@ -2,7 +2,7 @@
This code produces the Data Hub protocol. It preloads the data hub
with status information copied in from PEI HOBs.
-Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD
License
which accompanies this distribution. The full text of the license may be
found at
@@ -15,8 +15,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
EXPRESS OR IMPLIED.
#include "DataHub.h"
-CONST EFI_GUID gZeroGuid = { 0, 0, 0, { 0, 0, 0, 0, 0, 0, 0, 0 } };
-
//
// Since this driver will only ever produce one instance of the Logging Hub
// protocol you are not required to dynamically allocate the PrivateData.
diff --git a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h
b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h
index 2a4e760..de2e3f3 100644
--- a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h
+++ b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHub.h
@@ -2,7 +2,7 @@
This code supports a the private implementation
of the Data Hub protocol
-Copyright (c) 2006, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD
License
which accompanies this distribution. The full text of the license may be
found at
@@ -21,6 +21,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
EXPRESS OR IMPLIED.
#include <Protocol/DataHub.h>
+#include <Guid/ZeroGuid.h>
+
#include <Library/DebugLib.h>
#include <Library/UefiDriverEntryPoint.h>
#include <Library/UefiLib.h>
diff --git a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf
b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf
index 7845a89..834c3b3 100644
--- a/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf
+++ b/IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf
@@ -21,7 +21,7 @@
# drivers to be aware of all reporting formats.
# For more information, please ref http://www.intel.com/technology/framework/
#
-# Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD
License
@@ -56,6 +56,7 @@
[Packages]
IntelFrameworkPkg/IntelFrameworkPkg.dec
MdePkg/MdePkg.dec
+ MdeModulePkg/MdeModulePkg.dec
[LibraryClasses]
@@ -69,6 +70,10 @@
DebugLib
+[Guids]
+ gZeroGuid ## SOMETIMES_CONSUMES ## GUID
+
+
[Protocols]
gEfiDataHubProtocolGuid ## PRODUCES
--
1.9.5.msysgit.0
------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors
network devices and physical & virtual servers, alerts via email & sms
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
