Agree the commit message you provided. Thanks for your review effort and Reviewed-by.
Star -----Original Message----- From: Justen, Jordan L Sent: Monday, June 29, 2015 2:50 PM To: Zeng, Star; edk2-devel@lists.sourceforge.net Subject: RE: [edk2] [PATCH V2 10/24] EmulatorPkg: Link AuthVariableLib for following merged variable driver deploy. On 2015-06-28 22:25:49, Zeng, Star wrote: > I mean they are linked only by VaribleRuntimeDxe.inf. > > I guess you like this updated V3 patch for EmulatorPkg, right? How about this change to the commit message? === EmulatorPkg: Add TpmMeasurementLib and AuthVariableLib library mapping These library classes are now linked with MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf to optionally support secure variables. For EmulatorPkg, secure boot is not currently enabled, so we map these libraries to the NULL versions that don't support secure variables. === With a commit message similar to that, you can add my Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> to the patch you attached. Thanks, -Jordan > -----Original Message----- > From: Zeng, Star [mailto:star.z...@intel.com] > Sent: Monday, June 29, 2015 1:07 PM > To: Justen, Jordan L; edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] [PATCH V2 10/24] EmulatorPkg: Link AuthVariableLib for > following merged variable driver deploy. > > As they are linked by VaribleRuntimeDxe.inf. > You prefer to add them to library class section, right? If yes, I am ok to > move them to library class section. > In fact, I am neutral for that to link with the *.inf or library class > section. > > Thanks, > Star > -----Original Message----- > From: Justen, Jordan L > Sent: Monday, June 29, 2015 1:02 PM > To: Zeng, Star; edk2-devel@lists.sourceforge.net > Cc: Andrew Fish > Subject: Re: [PATCH V2 10/24] EmulatorPkg: Link AuthVariableLib for following > merged variable driver deploy. > > On 2015-06-26 01:37:47, Star Zeng wrote: > > Link AuthVariableLibNull and TpmMeasurementLibNull in MdeModulePkg. > > > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > > Cc: Andrew Fish <af...@apple.com> > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Star Zeng <star.z...@intel.com> > > --- > > EmulatorPkg/EmulatorPkg.dsc | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/EmulatorPkg/EmulatorPkg.dsc > > b/EmulatorPkg/EmulatorPkg.dsc index d02997c..c2f1a16 100644 > > --- a/EmulatorPkg/EmulatorPkg.dsc > > +++ b/EmulatorPkg/EmulatorPkg.dsc > > @@ -4,7 +4,7 @@ > > # The Emulation Platform can be used to debug individual modules, > > prior to creating # a real platform. This also provides an example for how > > an DSC is created. > > # > > -# Copyright (c) 2006 - 2013, Intel Corporation. All rights > > reserved.<BR> > > +# Copyright (c) 2006 - 2015, Intel Corporation. All rights > > +reserved.<BR> > > # Portions copyright (c) 2010 - 2011, Apple Inc. All rights > > reserved.<BR> # # This program and the accompanying materials @@ > > -312,7 +312,11 @@ > > EmulatorPkg/TimerDxe/Timer.inf > > > > > > - MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > > + MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { > > + <LibraryClasses> > > + > > + TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMe > > + TpmMeasurementLib|as > > + urementLibNull.inf > > + > > + AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVaria > > + AuthVariableLib|bl > > + eLibNull.inf > > + } > > Why not add these to the library classes sections rather than overriding for > the driver? > > -Jordan > > > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > > > > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf > > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > > -- > > 1.9.5.msysgit.0 > > > ---------------------------------------------------------------------- > -------- Monitor 25 network devices or servers for free with > OpManager! > OpManager is web-based network management software that monitors > network devices and physical & virtual servers, alerts via email & sms > for fault. Monitor 25 devices for free with no restriction. Download > now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Monitor 25 network devices or servers for free with OpManager! OpManager is web-based network management software that monitors network devices and physical & virtual servers, alerts via email & sms for fault. Monitor 25 devices for free with no restriction. Download now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
