Hi Jaben,
The patch looks good to me.
I think the comments for InternalShellStrHexToUint64 should also be updated.
The 'UINTN' in line 3731 and line 3808 should be 'UINT64'.
Reviewed-by: Qiu Shumin <[email protected]<mailto:[email protected]>>
From: Carsey, Jaben
Sent: Wednesday, July 01, 2015 5:35 AM
To: Qiu, Shumin; Shah, Tapan ([email protected])
Cc: [email protected]; El-Haj-Mahmoud, Samer
([email protected]); Carsey, Jaben
Subject: RE: [Patch] ShellPkg: fix string to number conversion with "0 "
I ran some more tests and found that I wanted one more line of code in the
patch. Please check this one instead.
From: Carsey, Jaben
Sent: Tuesday, June 30, 2015 1:54 PM
To: Qiu, Shumin; Shah, Tapan ([email protected]<mailto:[email protected]>)
Cc: [email protected]<mailto:[email protected]>;
El-Haj-Mahmoud, Samer
([email protected]<mailto:[email protected]>); Carsey, Jaben
Subject: [Patch] ShellPkg: fix string to number conversion with "0 "
Shumin / Tapan,
Can you review this?
This makes stopping at spaces work with only zero as the value. I also
attached a NSH file that can be used to verify the results. Before this the
loops from 0 to 3 would only execute once as the zero was converted as 3.
ShellPkg: fix string to number conversion with "0 "
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey
<[email protected]<mailto:[email protected]>>
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
