On 07/07/15 02:52, Jordan Justen wrote: > On 2015-07-06 15:10:45, Laszlo Ersek wrote: >> On 06/28/15 01:36, Jordan Justen wrote: >>> On 2015-06-25 21:26:20, Ni, Ruiyu wrote: >>>> Jordan, >>>> Simply using PCD to split the code is very straightforward. Another >>>> approach is to introduce a new library class with carefully defined >>>> library APIs so that different platforms can use one common driver >>>> plus different instances of libraries. >>>> After all, abstracting is never a easy work. >>>> So let's firstly make OVMF work by duplicating a PciHostBridgeDxe. >>> >>> Is this the preferred method of making progress then? Duplicate code >>> first, then figure out how to make it more general? I don't see >>> drivers duplicated all that often, so it seems a little strange. >>> >>> I haven't heard you say the PCD idea can't work, so can you spend a >>> little more time considering it to see if it seems reasonable to you? >>> If you are still concerned about the PCDs, then fine we'll just >>> duplicate the code. >>> >>> And, Laszlo, is this really that urgent that you'd rather duplicate a >>> driver under the platform rather than allowing for some discussion on >>> a possible common solution? >> >> I'm back from my PTO. After processing my email backlog, I can't find >> any news related to this patchset, so please consider it dropped, for >> the reasons described elsewhere in this thread. > > This continues to be very frustrating to me. I strongly disagree with > forking this driver. I have instead argued that we should make other > EDK II platforms use the same driver. > > But, it appears that Ray will not budge. (Or *something* is preventing > us from coming up with a solution in PcAtChipsetPkg.) This is doubly > frustrating since he is saying that we should keep the PcAtChipsetPkg > version that no one else is using because 'maybe some closed source > platform is using it'. > > I don't expect that the PcAtChipsetPkg version will ever be updated to > allow OVMF to go back to using it at the common location. Instead, it > will just be orphaned under PcAtChipsetPkg. > > I think Ray is just taking the easy/safe route with his decision. :( > > But, as much as this all annoys me, I find the prospect of you having > to carry downstream patches for this even worse.
Me too, to be honest. :( > > I'm just having trouble giving a Reviewed-by or Acked-by for patches > that are doing the opposite of what I want to happen. > > How about? > Acked-under-duress-by: Jordan Justen <jordan.l.jus...@intel.com> > > Better yet, how about I say that I'm specifically not NAK'ing the > patches, but I'd rather not have my name on them. I understand completely. Let me post a version 3 shortly, that leaves PcAtChipSetPkg alone (dropping patch #2), and updates the final bootorderlib patch slightly (as I promised earlier). Then you could skim the series, and respond with your Not-nacked-by: Jordan Justen <jordan.l.jus...@intel.com> formally. Or, if you don't want your name on it even in that double negative form, you could state the same on the mailing list only informally. (I'd prefer an explicit Not-nacked-by from you, under the circumstances, because that makes it clear in the commit history that you looked at the patches, and it points out your disagreement with some of the aspects. Otherwise the commit messages would (incorrectly) imply that I just went ahead and committed the patches without any feedback.) Would this work? "Not-nacked-by" is not the most traditional tag, admittedly, but the circumstances aren't either. Thanks! Laszlo > -Jordan > >> We'll carry the patches (with slight updates) in our downstream OVMF >> package, for <https://bugzilla.redhat.com/show_bug.cgi?id=1193080>. >> >> I'll ask Gerd too to add them to his <https://www.kraxel.org/repos/> >> builds, for the benefit of the wider public. ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
