On 7 July 2015 at 13:48, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote:
> On 7 July 2015 at 14:46, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote:
> > On 7 July 2015 at 03:27, jiaxinwu <jiaxin...@intel.com> wrote:
> >> Those patches are used to remove Ip4ConfigDxe module and related guid
> definitions from related packages.
> >>
> >
> > Could you please explain *why* you are removing these?
> >
>
> OK, never mind. I found it in a followup message.
>
> Next time, could you please put it in the commit messages? Changes
> should either be self-explanatory or their purpose should be stated in
> the associated commit message instead of the reviewers having to track
> them down.
>
I had the same problem!
As these patches aren't merged yet, I think they should be re-submitted
with a proper commit message.
So I'd give this series a NACK.
>
> Regards,
> Ard.
>
>
> >> jiaxinwu (7):
> >> MdeModulePkg: Remove Ip4ConfigDxe module and related guid definition
> >> from MdeModulePkg.
> >> Nt32Pkg: Remove Ip4ConfigDxe module from Nt32Pkg.
> >> OvmfPkg: Remove Ip4ConfigDxe module from OvmfPkg.
> >> ArmPlatformPkg: Remove Ip4ConfigDxe module from ArmPlatformPkg.
> >> ArmVirtPkg: Remove Ip4ConfigDxe module from ArmVirtPkg.
> >> EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg.
> >> Vlv2TbltDevicePkg: Remove Ip4ConfigDxe module from Vlv2TbltDevicePkg.
> >>
> >> ArmPlatformPkg/ArmJunoPkg/ArmJuno.fdf | 1 -
> >> .../ArmVExpressPkg/ArmVExpress-CTA15-A7.fdf | 1 -
> >> .../ArmVExpressPkg/ArmVExpress-CTA9x4.fdf | 1 -
> >> .../ArmVExpressPkg/ArmVExpress-RTSM-A15.fdf | 1 -
> >> .../ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.fdf | 1 -
> >> ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 1 -
> >> ArmVirtPkg/ArmVirt.dsc.inc | 1 -
> >> ArmVirtPkg/ArmVirtQemu.fdf | 1 -
> >> EmulatorPkg/EmulatorPkg.dsc | 1 -
> >> EmulatorPkg/EmulatorPkg.fdf | 3 +-
> >> MdeModulePkg/Include/Guid/Ip4ConfigHii.h | 25 -
> >> MdeModulePkg/Include/Guid/NicIp4ConfigNvData.h | 70 --
> >> MdeModulePkg/MdeModulePkg.dec | 6 -
> >> MdeModulePkg/MdeModulePkg.dsc | 1 -
> >> .../Universal/Network/Ip4ConfigDxe/ComponentName.c | 165 ----
> >> .../Universal/Network/Ip4ConfigDxe/Ip4Config.c | 745
> -----------------
> >> .../Universal/Network/Ip4ConfigDxe/Ip4Config.h | 533 ------------
> >> .../Network/Ip4ConfigDxe/Ip4ConfigDriver.c | 505 ------------
> >> .../Network/Ip4ConfigDxe/Ip4ConfigDxe.inf | 91 ---
> >> .../Network/Ip4ConfigDxe/Ip4ConfigDxe.uni | Bin 2700 -> 0
> bytes
> >> .../Network/Ip4ConfigDxe/Ip4ConfigDxe.vfr | 89 --
> >> .../Network/Ip4ConfigDxe/Ip4ConfigDxeExtra.uni | Bin 1366 -> 0
> bytes
> >> .../Network/Ip4ConfigDxe/Ip4ConfigDxeStrings.uni | Bin 3000 -> 0
> bytes
> >> .../Universal/Network/Ip4ConfigDxe/Ip4ConfigNv.c | 909
> ---------------------
> >> .../Universal/Network/Ip4ConfigDxe/Ip4ConfigNv.h | 54 --
> >> .../Universal/Network/Ip4ConfigDxe/Ip4NvData.h | 48 --
> >> .../Network/Ip4ConfigDxe/NicIp4Variable.c | 319 --------
> >> .../Network/Ip4ConfigDxe/NicIp4Variable.h | 104 ---
> >> Nt32Pkg/Nt32Pkg.dsc | 1 -
> >> Nt32Pkg/Nt32Pkg.fdf | 1 -
> >> OvmfPkg/OvmfPkgIa32.dsc | 1 -
> >> OvmfPkg/OvmfPkgIa32.fdf | 1 -
> >> OvmfPkg/OvmfPkgIa32X64.dsc | 1 -
> >> OvmfPkg/OvmfPkgIa32X64.fdf | 1 -
> >> OvmfPkg/OvmfPkgX64.dsc | 1 -
> >> OvmfPkg/OvmfPkgX64.fdf | 1 -
> >> Vlv2TbltDevicePkg/PlatformPkg.fdf | 1 -
> >> Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 1 -
> >> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 -
> >> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 -
> >> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 -
> >> 41 files changed, 1 insertion(+), 3688 deletions(-)
> >> delete mode 100644 MdeModulePkg/Include/Guid/Ip4ConfigHii.h
> >> delete mode 100644 MdeModulePkg/Include/Guid/NicIp4ConfigNvData.h
> >> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/ComponentName.c
> >> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4Config.c
> >> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4Config.h
> >> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDriver.c
> >> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.inf
> >> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.uni
> >> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.vfr
> >> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxeExtra.uni
> >> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxeStrings.uni
> >> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigNv.c
> >> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigNv.h
> >> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4NvData.h
> >> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/NicIp4Variable.c
> >> delete mode 100644
> MdeModulePkg/Universal/Network/Ip4ConfigDxe/NicIp4Variable.h
> >>
> >> --
> >> 1.9.5.msysgit.1
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> Don't Limit Your Business. Reach for the Cloud.
> >> GigeNET's Cloud Solutions provide you with the tools and support that
> >> you need to offload your IT needs and focus on growing your business.
> >> Configured For All Businesses. Start Your Cloud Today.
> >> https://www.gigenetcloud.com/
> >> _______________________________________________
> >> edk2-devel mailing list
> >> edk2-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/edk2-devel
>
>
> ------------------------------------------------------------------------------
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that
> you need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel
>
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
