1-19 Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com>

On 2015-07-07 08:09:21, Laszlo Ersek wrote:
> This field was supposed to store the number of root buses created; however
> we don't need to keep that count persistently. After the entry point returns,
> nothing reads this field.
> 
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <ler...@redhat.com>
> Regression-tested-by: Gabriel Somlo <so...@cmu.edu>
> ---
>  OvmfPkg/PciHostBridgeDxe/PciHostBridge.h | 1 -
>  OvmfPkg/PciHostBridgeDxe/PciHostBridge.c | 4 +---
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/OvmfPkg/PciHostBridgeDxe/PciHostBridge.h 
> b/OvmfPkg/PciHostBridgeDxe/PciHostBridge.h
> index d2c28bc..617c68e 100644
> --- a/OvmfPkg/PciHostBridgeDxe/PciHostBridge.h
> +++ b/OvmfPkg/PciHostBridgeDxe/PciHostBridge.h
> @@ -52,7 +52,6 @@ typedef enum {
>  typedef struct {
>    UINTN                                             Signature;
>    EFI_HANDLE                                        HostBridgeHandle;
> -  UINTN                                             RootBridgeNumber;
>    LIST_ENTRY                                        Head;
>    BOOLEAN                                           ResourceSubmited;
>    BOOLEAN                                           CanRestarted;
> diff --git a/OvmfPkg/PciHostBridgeDxe/PciHostBridge.c 
> b/OvmfPkg/PciHostBridgeDxe/PciHostBridge.c
> index a5dbe57..7dda75f 100644
> --- a/OvmfPkg/PciHostBridgeDxe/PciHostBridge.c
> +++ b/OvmfPkg/PciHostBridgeDxe/PciHostBridge.c
> @@ -56,7 +56,6 @@ EFI_HANDLE mDriverImageHandle;
>  PCI_HOST_BRIDGE_INSTANCE mPciHostBridgeInstanceTemplate = {
>    PCI_HOST_BRIDGE_SIGNATURE,  // Signature
>    NULL,                       // HostBridgeHandle
> -  0,                          // RootBridgeNumber
>    {NULL, NULL},               // Head
>    FALSE,                      // ResourceSubiteed
>    TRUE,                       // CanRestarted
> @@ -213,7 +212,6 @@ InitializePciHostBridge (
>      return EFI_OUT_OF_RESOURCES;
>    }
>  
> -  HostBridge->RootBridgeNumber = 1;
>    InitializeListHead (&HostBridge->Head);
>  
>    Status = gBS->InstallMultipleProtocolInterfaces (
> @@ -227,7 +225,7 @@ InitializePciHostBridge (
>    }
>  
>    for (RootBridgeNumber = 0;
> -       RootBridgeNumber < HostBridge->RootBridgeNumber;
> +       RootBridgeNumber < 1;
>         ++RootBridgeNumber) {
>      Status = InitRootBridge (
>                 (UINT8)RootBridgeNumber,
> -- 
> 1.8.3.1
> 
> 

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to