On 8 July 2015 at 15:35, Wu, Jiaxin <[email protected]> wrote:
> Hi Ard,
> Please help to review and reply the patch, if so, I can submit the patch as 
> soon as possible.
>
> Thank you very much!
>

I just tested it and it works.
So please feel free to add

Reviewed-by: Ard Biesheuvel <[email protected]>

Thanks,
Ard.

> -----Original Message-----
> From: Jiaxin Wu [mailto:[email protected]]
> Sent: Wednesday, July 8, 2015 8:19 PM
> To: [email protected]; Ard Biesheuvel
> Subject: [edk2] [Patch] ShellPkg: Remove Status definition in function scope
>
> This patch is used fix gcc build failure issue by removing 'Status' 
> definition in function scope that are assigned but never used afterwards.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiaxin Wu <[email protected]>
> ---
>  ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c 
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
> index 6977d6b..df19a9f 100644
> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
> @@ -515,19 +515,16 @@ ON_ERROR:
>  EFI_STATUS
>  IfConfigShowInterfaceInfo (
>    IN LIST_ENTRY    *IfList
>    )
>  {
> -  EFI_STATUS                Status;
>    LIST_ENTRY                *Entry;
>    LIST_ENTRY                *Next;
>    IFCONFIG_INTERFACE_CB     *IfCb;
>    EFI_IPv4_ADDRESS          Gateway;
>    UINT32                    Index;
>
> -  Status = EFI_SUCCESS;
> -
>    if (IsListEmpty (IfList)) {
>      ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN 
> (STR_IFCONFIG_INVALID_INTERFACE), gShellNetwork1HiiHandle);
>    }
>
>    //
> --
> 1.9.5.msysgit.1
>
>
>
> ------------------------------------------------------------------------------
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that
> you need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> _______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/edk2-devel

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to