On Tue, Jul 14, 2015 at 02:59:00PM +0100, Olivier Martin wrote: > From: Brendan Jackman <[email protected]> > > This improves performance for dumb filesystem drivers > as block sizes tend to be more 4Kb size than 1000bit
OK, so serious nitpicking, but: 4KB and 1000 bytes. Change those, and Reviewed-by: Leif Lindholm <[email protected]> > size. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Brendan Jackman <[email protected]> > Reviewed-by: Olivier Martin <[email protected]> > --- > ShellPkg/ShellPkg.dec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ShellPkg/ShellPkg.dec b/ShellPkg/ShellPkg.dec > index 32c0aff..b2f6326 100644 > --- a/ShellPkg/ShellPkg.dec > +++ b/ShellPkg/ShellPkg.dec > @@ -100,7 +100,7 @@ > gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength|50|UINT8|0x00000009 > > ## This determines how many bytes are read out of files at a time for file > operations (type, copy, etc...) > - gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize|1000|UINT32|0x0000000A > + > gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize|0x1000|UINT32|0x0000000A > > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > ## This flag is used to control the protocols produced by the shell > -- > 2.1.1 > > > ------------------------------------------------------------------------------ > Don't Limit Your Business. Reach for the Cloud. > GigeNET's Cloud Solutions provide you with the tools and support that > you need to offload your IT needs and focus on growing your business. > Configured For All Businesses. Start Your Cloud Today. > https://www.gigenetcloud.com/ > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ edk2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/edk2-devel
