Hi Felipe and Ned, I've created this pull request to support unicode usernames. More details in the pull request:
- https://github.com/edx/edx-platform/pull/12805 Thanks, On Wednesday, May 25, 2016 at 1:52:59 AM UTC+3, Felipe Montoya wrote: > > Hello Omar! > > Thanks a lot for your work on supporting special characters for usernames. > Your fork was the first stop in our research to get that working for us a > few months ago. If you need any help with this or you ever want to discuss > any problems you find with those usernames, let me know and I will be happy > to help. > > > Cheers > -- > Felipe > > On Tuesday, May 24, 2016 at 5:32:35 AM UTC-5, Ned Batchelder wrote: >> >> Omar, great to hear! If there is work needed to get the changes ready, >> maybe someone here would like to help? >> >> --Ned. >> >> On Sun, May 22, 2016 at 4:52 AM, Omar Al-Ithawi <[email protected]> wrote: >> >>> Hi Ned, >>> >>> Yes, I would like to contribute those changes. I didn't do it, because >>> they have potential Django compatibility issues (which we try actively to >>> solve, and has been successful so far). Also I wasn't sure that the openedx >>> would be interested in this feature. >>> >>> I will put it on my list and try to work on it once I have time. >>> >>> Thanks, >>> >>> On Thu, May 19, 2016 at 5:38 PM, Ned Batchelder <[email protected]> wrote: >>> >>>> Omar, are you planning to contribute these changes back into the common >>>> code? It seems like others would like to have them. Is there a reason >>>> not >>>> to contribute them? >>>> >>>> --Ned. >>>> >>>> On Wed, May 18, 2016 at 2:44 PM, Omar Al-Ithawi <[email protected]> wrote: >>>> >>>>> Hi All, >>>>> >>>>> It's my pleasure to help on this. >>>>> >>>>> At Edraak.org we try to support the unicode usernames (with spaces) >>>>> and so far we're doing well. >>>>> >>>>> I know this is against Django but it is working fine with us, even in >>>>> Dogwood. >>>>> >>>>> I know this is needed in a lot of global edX installations, but not >>>>> sure if edX is willing to take it as an opensource contribution. >>>>> >>>>> Since this is an ongoing process at Edraak (to support unicode >>>>> everywhere), the following pull requests are an example of what we did: >>>>> >>>>> >>>>> - Allow editing users with unicode usernames >>>>> <https://github.com/Edraak/edx-platform/pull/167> >>>>> - Allow Arabic username in combined registration form >>>>> <https://github.com/Edraak/edx-platform/pull/103> >>>>> - Fixed unicode decode issue with csv grades >>>>> <https://github.com/Edraak/edx-platform/pull/28> >>>>> - Fix Unicode error in `/dashboard` >>>>> <https://github.com/Edraak/edx-platform/pull/22> >>>>> - Allowed unicode in usernames >>>>> <https://github.com/Edraak/edx-platform/pull/2> >>>>> >>>>> >>>>> Thanks, >>>>> >>>>> On Monday, May 16, 2016 at 10:45:42 PM UTC+3, Ned Batchelder wrote: >>>>>> >>>>>> Rajeev, >>>>>> >>>>>> This thread doesn't describe what goes wrong if you use non-ASCII in >>>>>> the Public Username. Can you give it a quick try and tell us what you >>>>>> find? >>>>>> >>>>>> --Ned. >>>>>> >>>>>> On Mon, May 16, 2016 at 1:51 PM, <[email protected]> wrote: >>>>>> >>>>>>> Hello Sarina, >>>>>>> is this still the case with the 2016 release of open edx? >>>>>>> >>>>>>> -Rajeev >>>>>>> >>>>>>> On Friday, June 5, 2015 at 11:54:23 PM UTC-5, Sarina Canelake wrote: >>>>>>>> >>>>>>>> I don't know if there's a specific reason for it, but I would think >>>>>>>> that there's a lot of code in the platform that wouldn't cleanly >>>>>>>> handle >>>>>>>> unicode appearing in usernames. I would recommend against just turning >>>>>>>> it >>>>>>>> on - you would need to run the full test suite and see what all might >>>>>>>> fail >>>>>>>> from unicode usernames --- and even then, errors likely would appear, >>>>>>>> because we likely have lots of apps who don't even test against a >>>>>>>> unicode >>>>>>>> username. >>>>>>>> >>>>>>>> Sorry about that. >>>>>>>> >>>>>>>> Sarina >>>>>>>> >>>>>>>> On Tue, Jun 2, 2015 at 5:24 AM, <[email protected]> wrote: >>>>>>>> >>>>>>>>> Using special characters on the file "Public Username" in edx is >>>>>>>>> forbidden. I assume there are technical reasons for that? Or may I >>>>>>>>> turn off >>>>>>>>> this restrictions somehow? >>>>>>>>> >>>>>>>>> -- >>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>> Groups "General Open edX discussion" group. >>>>>>>>> To view this discussion on the web visit >>>>>>>>> https://groups.google.com/d/msgid/edx-code/2cb5da1a-24d5-4045-bd7d-9552c562ff02%40googlegroups.com >>>>>>>>> >>>>>>>>> <https://groups.google.com/d/msgid/edx-code/2cb5da1a-24d5-4045-bd7d-9552c562ff02%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>>>>>> . >>>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "General Open edX discussion" group. >>>>>>> To view this discussion on the web visit >>>>>>> https://groups.google.com/d/msgid/edx-code/07fadd04-0757-4238-8e15-35c2fac1ff01%40googlegroups.com >>>>>>> >>>>>>> <https://groups.google.com/d/msgid/edx-code/07fadd04-0757-4238-8e15-35c2fac1ff01%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>>>> . >>>>>>> >>>>>> >>>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "General Open edX discussion" group. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/edx-code/5bdf4155-9633-4897-a739-ca5b402714b9%40googlegroups.com >>>>> >>>>> <https://groups.google.com/d/msgid/edx-code/5bdf4155-9633-4897-a739-ca5b402714b9%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> >>>> -- >>>> You received this message because you are subscribed to a topic in the >>>> Google Groups "General Open edX discussion" group. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/edx-code/CAGtJPNNkax18SceFrB1Do3o9pFwUa%3DqpiFOnb4KhdFbnsx5DbQ%40mail.gmail.com >>>> >>>> <https://groups.google.com/d/msgid/edx-code/CAGtJPNNkax18SceFrB1Do3o9pFwUa%3DqpiFOnb4KhdFbnsx5DbQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> >>> >>> >>> -- >>> Omar Al-Ithawi >>> >>> Senior Engineer, Edraak.org <http://www.edraak.org/> >>> >>> >>> Queen Rania Foundation >>> >>> for Education & Development >>> >>> T +962 6 4016464 Ext. 700 >>> >>> M +962 7 90574405 >>> >>> E [email protected] >>> >>> <https://twitter.com/edraak> <https://www.facebook.com/edraakorg> >>> <http://www.youtube.com/user/edraakorg> <http://instagram.com/edraakorg> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "General Open edX discussion" group. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/edx-code/CA%2BAzJzFz7ZeAy-Rry-aiV-DF6BQ5iU4hGKoiaHSNnQSAHnM0VA%40mail.gmail.com >>> >>> <https://groups.google.com/d/msgid/edx-code/CA%2BAzJzFz7ZeAy-Rry-aiV-DF6BQ5iU4hGKoiaHSNnQSAHnM0VA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> >> -- You received this message because you are subscribed to the Google Groups "General Open edX discussion" group. To view this discussion on the web visit https://groups.google.com/d/msgid/edx-code/ee27e578-ee9a-49b3-a417-a6ace9e3fa41%40googlegroups.com.
