Correction: here are the links for stylelint-config-edx: - GitHub: https://github.com/edx/stylelint-config-edx - npm: https://www.npmjs.com/package/@edx/stylelint-config-edx
On Wed, Sep 13, 2017 at 9:22 AM, Andy Armstrong <[email protected]> wrote: > *TLDR; Sass linting is now available in edx-platform and can be used by > any IDAs.* > > With all the upcoming work on our Sass and with the switch to Bootstrap, > the FedX team decided to implement a Sass linter for use within our > applications. We chose stylelint which, much like eslint, supports the > ability to have an npm package containing shared linting rules. We mostly > adopted the recommended set of rules, which are documented here: > > - CSS rules > > <https://github.com/stylelint/stylelint/blob/master/docs/user-guide/rules.md#possible-errors> > - SCSS-specific rules > <https://www.npmjs.com/package/stylelint-scss#list-of-rules> > > The Jenkins quality build for the edx-platform repo now runs the linter > automatically, so your PR will fail if your Sass changes don't follow the > rules. In addition, there is a new npm package that can be installed into > any IDA to provide the same validation: > > https://github.com/edx/eslint-config-edx > > Most code editors should pick up our eslint and stylelint configs so that > you can see violations as you work. For more details, see here: > > https://openedx.atlassian.net/wiki/spaces/OpenDev/pages/ > 92209202/Editors+IDEs > > Please let me know if you have any questions. > > Thanks, > > - Andy > > P.S. We haven't yet fixed all of the Sass violations in edx-platform > (there are over 15,000 of them!), so as with most of our linters there is > an expected number of violations defined that can't be exceeded. > > -- > > *Andy Armstrong* > > edX | UI Architect | [email protected] > > 141 Portland Street, 9th floor > > Cambridge, MA 02139 > http://www.edx.org <http://www.edxonline.org/> > > [image: > http://www.e-learn.nl/media/blogs/e-learn/edX_Logo_Col_RGB_FINAL.jpg?mtime=1336074566] > -- *Andy Armstrong* edX | UI Architect | [email protected] 141 Portland Street, 9th floor Cambridge, MA 02139 http://www.edx.org <http://www.edxonline.org/> [image: http://www.e-learn.nl/media/blogs/e-learn/edX_Logo_Col_RGB_FINAL.jpg?mtime=1336074566] -- You received this message because you are subscribed to the Google Groups "General Open edX discussion" group. To view this discussion on the web visit https://groups.google.com/d/msgid/edx-code/CAG2ZmnBSj-J%2BzNCppj6rwU-aUMqX%2BWNJ7mqjAFg%2BC48eQ_ffnQ%40mail.gmail.com.
