Thanks everyone, this is very helpful. --Ned.
On Fri, Jan 18, 2019 at 5:49 PM Jill Vogel <[email protected]> wrote: > Hi Ned! > > Why not tag the apps, and then let people decide for themselves if they >> want to use a tagged open-edx release, or if they want to use master? >> > > +1 to this! > > *J'aime* is totally correct, that usually, the API changes between > versions are minimal, and so you can run master mobile apps against the > latest named release with no issue. And we like to stick to master for the > apps, because then our users get all the latest greatest features. > > But with Hawthorn and the latest master iOS app, we had a few issues that > weren't well documented: > > - Authentication for HTML/Problem content now requires Django OAuth > Toolkit Application integration, cf comment on edx-app-ios#1222 > <https://github.com/edx/edx-app-ios/pull/1222#issuecomment-451393218> > There's a link there to the Slack discussion. > Probably too late to go in the Hawthorn release notes, and it's > possible the change wasn't in iOS master when Hawthorn was released? > - The above authentication change also required configuration#4937 > <https://github.com/edx/configuration/pull/4937> for us, since we have > a load-balancer that sends basic auth to the backends, and DOT treats basic > auth headers differently from the old DOP auth did. > - Mobile API v1 not in Hawthorn (only v0.5). edx-app-ios#1222 > <https://github.com/edx/edx-app-ios/pull/1222> also alludes to this, > but since the iOS app is gradually converting from v0.5 to v1 endpoints, we > chose to close this PR, taking into account all the client changes that > might be required to support both versions was more complex than we had > time to manage. > *Pierre*, this might be the issue you're seeing? > > Having a named release tag on the iOS app would have helped with both of > these issues! > > The authentication change would still require a config change (and we > still would have needed configuration#4937) > <https://github.com/edx/configuration/pull/4937> but a warning in the > named Release Notes would have at least alerted us to the problem. > > Cheers, > -- > Jill > @OpenCraft > <http://opencraft.com/> > > > On Sat, Jan 19, 2019 at 7:33 AM Pierre Mailhot <[email protected]> > wrote: > >> Ned, I tried compiling master through Android Studio for the mobile app. >> >> It compiles, it installs but it won't show me the courses on the >> dashboard. It is complaining of an unknown error. >> >> I checked out release/2.16.4 which is still using the old enrollment API >> and everything works without a problem. >> >> At this point, I cannot say master works with Hawthorn. >> >> On Wednesday, January 16, 2019 at 11:58:10 AM UTC-5, Ned Batchelder wrote: >>> >>> Oh, and one other thing: Why not tag the apps, and then let people >>> decide for themselves if they want to use a tagged open-edx release, or if >>> they want to use master? >>> >>> --Ned. >>> >>> On Wed, Jan 16, 2019 at 11:57 AM Ned Batchelder <[email protected]> wrote: >>> >>>> J'aime, thanks for your perspective. I'm still trying to understand: >>>> does the master of the mobile apps work against Hawthorn? You say they >>>> work against Ginkgo, so how could they be broken against Hawthorn? You >>>> mentioned cherry-picking, is that picking changes to the mobile app, or to >>>> the server? >>>> >>>> --Ned. >>>> >>>> On Wed, Jan 16, 2019 at 1:41 AM J'aime Ohm <[email protected]> >>>> wrote: >>>> >>>>> I agree with Lupus and Ned that it is best to stay on latest for >>>>> mobile. Changes to the API are generally minor or nonexistent between >>>>> versions and are easy to cherrypick. I'm running master against a Ficus >>>>> and >>>>> a Ginkgo instance and will be running against a Hawthorne instance when >>>>> it's ready for me in the next couple of months. My situation is similar to >>>>> Pierre's, except I'm running master against even older backend(s). >>>>> >>>>> I agree with Pierre, the cherrypicking is annoying. I've found the >>>>> changes are minor though, for avoiding a change. To avoid having people >>>>> cherrypick, the mobile team might consider keeping small API changes >>>>> behind >>>>> feature flags for a platform release or two. >>>>> >>>>> Some reasons to stay on master include... >>>>> - older versions of an app often don't run as-is, even if the version >>>>> of Xcode, OS, Swift, and Android Studio are named, because of changes by >>>>> Apple that affect this and are uncontrollable >>>>> - it's more natural to contribute PRs if you're testing and running >>>>> against master >>>>> - like Lupus says, security updates >>>>> - other maintenance updates that may be time sensitive, like support >>>>> for new devices or new operating systems or new requirements by the stores >>>>> >>>>> >>>>> >>>>> On Tuesday, January 15, 2019 at 1:14:15 PM UTC-8, Lupus Furyo wrote: >>>>>> >>>>>> Hi Ned, >>>>>> I was replying from my gmail inbox, I did not see Pierre's last reply >>>>>> regarding usability. My remark was of general type, especially concerning >>>>>> Sec of an App. Mobile apps get updated too often due to known concerns. >>>>>> Perhaps, this is why Marco does not like tagging Open edX App with >>>>>> named.releases. Anyways, please ignore my remark regarding this matter. >>>>>> Pierre has already elaborated his question and suggestion thoroughly. >>>>>> >>>>>> Best, L. >>>>>> >>>>>> >>>>>> On Wed, Jan 16, 2019 at 12:30 AM Ned Batchelder <[email protected]> wrote: >>>>>> >>>>>>> Lupus, can you explain why that is? Did you see Pierre's experience >>>>>>> that the latest mobile app didn't work with Hawthorn? >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> --Ned. >>>>>>> >>>>>>> On Tue, Jan 15, 2019 at 11:48 AM Lupus Furyo <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> In case of mobile clients, generally, it is always better to stick >>>>>>>> to master. This does not concern Open edX only. >>>>>>>> >>>>>>>> On Tue, Jan 15, 2019 at 4:35 PM Ned Batchelder <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Robert, >>>>>>>>> >>>>>>>>> I asked Marco Morales about this, and he said, "I'm not convinced >>>>>>>>> it is all that helpful to pin or tag these specifically? We publicize >>>>>>>>> named >>>>>>>>> platform release dates, mobile release version dates (with github >>>>>>>>> tags). >>>>>>>>> I'd rather people stay closer to master for mobile (which they >>>>>>>>> generally >>>>>>>>> do) rather than tracking all breaking changes across the two." >>>>>>>>> >>>>>>>>> What do you think of that? >>>>>>>>> >>>>>>>>> --Ned. >>>>>>>>> >>>>>>>>> On Thu, Jan 10, 2019 at 2:34 PM Ned Batchelder <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Robert, >>>>>>>>>> >>>>>>>>>> I believe we will be tagging them for Ironwood, yes. >>>>>>>>>> >>>>>>>>>> --Ned. >>>>>>>>>> >>>>>>>>>> On Wed, Jan 9, 2019 at 11:55 AM Robert Gérin-Lajoie < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Ned, will you tag the mobile apps (iOS and Android) with >>>>>>>>>>> Ironwood? >>>>>>>>>>> >>>>>>>>>>> Robert >>>>>>>>>>> >>>>>>>>>>> Le mardi 8 janvier 2019 15:52:52 UTC-5, Ned Batchelder a écrit : >>>>>>>>>>>> >>>>>>>>>>>> Hey everyone, >>>>>>>>>>>> >>>>>>>>>>>> The next release of the Open edX software is "Ironwood." We >>>>>>>>>>>> are getting ready to start the release process. The first step is >>>>>>>>>>>> creating >>>>>>>>>>>> the open-release/ironwood.master branches in the appropriate >>>>>>>>>>>> repos. I plan >>>>>>>>>>>> to do this on Friday, January 18th. >>>>>>>>>>>> >>>>>>>>>>>> Anything merged by that date will be part of Ironwood; anything >>>>>>>>>>>> merged after that date will have to wait for the next release. >>>>>>>>>>>> >>>>>>>>>>>> A week or two after the branches are created, we will have a >>>>>>>>>>>> beta for everyone to test. Then after a few weeks of community >>>>>>>>>>>> testing, >>>>>>>>>>>> Ironwood will be officially released. >>>>>>>>>>>> >>>>>>>>>>>> If you have any questions or concerns, respond to this thread, >>>>>>>>>>>> or send an email to [email protected]. >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> >>>>>>>>>>>> --Ned. >>>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>>> Google Groups "General Open edX discussion" group. >>>>>>>>>>> To view this discussion on the web visit >>>>>>>>>>> https://groups.google.com/d/msgid/edx-code/76a8f4e8-5a7e-4683-8b6c-75c76f4eeb00%40googlegroups.com >>>>>>>>>>> <https://groups.google.com/d/msgid/edx-code/76a8f4e8-5a7e-4683-8b6c-75c76f4eeb00%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>>>>>>>> . >>>>>>>>>>> >>>>>>>>>> -- >>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>> Groups "General Open edX discussion" group. >>>>>>>>> To view this discussion on the web visit >>>>>>>>> https://groups.google.com/d/msgid/edx-code/CAGtJPNPsxeXas_WKonGVpMAmpZQMevTRYffbzroT%3DAeSo57PhQ%40mail.gmail.com >>>>>>>>> <https://groups.google.com/d/msgid/edx-code/CAGtJPNPsxeXas_WKonGVpMAmpZQMevTRYffbzroT%3DAeSo57PhQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>>> . >>>>>>>>> >>>>>>>> -- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "General Open edX discussion" group. >>>>>>>> To view this discussion on the web visit >>>>>>>> https://groups.google.com/d/msgid/edx-code/CA%2BaB0d-rmF%3D%3DUtB3yF3J9Urw4ugRPizYu6v69099tCXneh40jA%40mail.gmail.com >>>>>>>> <https://groups.google.com/d/msgid/edx-code/CA%2BaB0d-rmF%3D%3DUtB3yF3J9Urw4ugRPizYu6v69099tCXneh40jA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>> . >>>>>>>> >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "General Open edX discussion" group. >>>>>>> To view this discussion on the web visit >>>>>>> https://groups.google.com/d/msgid/edx-code/CAGtJPNNC%2BTZnode7aQz6h%2BDHh%3D48dWg%3Dy4RrGna9ERY8FRXN5g%40mail.gmail.com >>>>>>> <https://groups.google.com/d/msgid/edx-code/CAGtJPNNC%2BTZnode7aQz6h%2BDHh%3D48dWg%3Dy4RrGna9ERY8FRXN5g%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>> . >>>>>>> >>>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "General Open edX discussion" group. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/edx-code/243bf16d-d148-46b0-a316-d6561e51594d%40googlegroups.com >>>>> <https://groups.google.com/d/msgid/edx-code/243bf16d-d148-46b0-a316-d6561e51594d%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> -- >> You received this message because you are subscribed to the Google Groups >> "General Open edX discussion" group. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/edx-code/2d673519-3c50-4a1d-b31e-706b46418e8f%40googlegroups.com >> <https://groups.google.com/d/msgid/edx-code/2d673519-3c50-4a1d-b31e-706b46418e8f%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "General Open edX discussion" group. > To view this discussion on the web visit > https://groups.google.com/d/msgid/edx-code/CAMZ1At%2B4%3D9-S4uKNfV2wRyurjwTtHUhZjvgq6CGSoDXWz8PFMg%40mail.gmail.com > <https://groups.google.com/d/msgid/edx-code/CAMZ1At%2B4%3D9-S4uKNfV2wRyurjwTtHUhZjvgq6CGSoDXWz8PFMg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "General Open edX discussion" group. To view this discussion on the web visit https://groups.google.com/d/msgid/edx-code/CAGtJPNO47geiEtiw-j4U_LdbKXmJQ4YKvyD9n7Fsn1Xz5dSUPw%40mail.gmail.com.
