Hi Andreas, On Tue, 2017-10-24 at 17:50 +0200, Andreas Reichel wrote: > On Tue, Oct 24, 2017 at 04:20:07PM +0200, Claudius Heine wrote: > > Hi, > > > > since we seems to like clean structured patchesets in efibootguard, > > this patch could be mostly merged into previous patches of this > > set. > > Just because you disagree about the separation does not mean, > my patchset is unclean.
Ok maybe 'clean' is not the right word because it contains a bias. I
don't disagree with your separation per se. I do it in my own projects
often enough. I just pointed out that there two (at least) different
methods to do these things. 1: patches represent the development
process and 2: patches introduce or change specific features ('cleaned
up', 'structured', 'post processed', ...).
IMO if one patch in a patchset breaks something (in this case travis or
in some other cases the documentation) and then a latter patch fixes
this again than this sounds more like method 1 to me.
I do see arguments to have a separate patch at the end of a patchset
that fixes the documentation, and that might be ok, because that is not
technical. But travis is.
Claudius
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: [email protected]
PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
Keyserver: hkp://pool.sks-keyservers.net
--
You received this message because you are subscribed to the Google Groups "EFI
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/efibootguard-dev/1508862049.13007.90.camel%40denx.de.
For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: This is a digitally signed message part
