On Mon, Nov 20, 2017 at 12:28:18PM +0100, Jan Kiszka wrote: > On 2017-11-17 17:32, Andreas J. Reichel wrote: > > From: Andreas Reichel <[email protected]> > > > > Global variables are removed to avoid a regression regarding the > > robustness of the update mechanism. > > > > Furthermore, an improvement to the 'setglobalstate' function of the API > > is added to reduce unnecessary environment modifications and to add > > further support to recover from usually non-occuring update states. > > Err, you need to help me: Why do we still have a setglobalstate API when > global vars are removed? Shouldn't that one go as well? > That is okay :) The name 'globalstate' refers to ustate and was chosen as such, because in case of failure, ALL environments are searched for ustate == FAILED and revision == 0. That's why.
The setter only modifies environments that are marked as FAILED if setting the state to OK. If setting the state to another value, only the current environment is accessed. Andreas > Jan > > > > > Signed-off-by: Andreas Reichel <[email protected]> > > > > Andreas Reichel (2): > > Remove global user variables > > ustate: Enhance API function to reset ustate > > > > docs/API.md | 23 ++++---------------- > > docs/TOOLS.md | 2 +- > > env/env_api.c | 12 +++++++---- > > env/env_api_fat.c | 39 > > ---------------------------------- > > include/ebgenv.h | 3 +-- > > include/env_api.h | 2 -- > > tools/tests/test_ebgenv_api_internal.c | 26 +---------------------- > > 7 files changed, 15 insertions(+), 92 deletions(-) > > > -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant [email protected], +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082 -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/20171120122519.GA2979%40iiotirae. For more options, visit https://groups.google.com/d/optout.
