Hi Dimitri,
On 02/01/2018 03:00 PM, [email protected] wrote:
Hi Claudius,
I'm still learning about submitting patches via email, so please bear with
me :-) Could you please explain what do you mean by "versioning patches"?
Don't worry, we all were there once :)
I do like this:
git format-patch --subject-prefix='PATCH v2' ...
Then the subject of all patches changes from '[PATCH]' to '[PATCH v2]'.
This helps reviewers to find the latest version of a patch in a busy inbox.
I did rebase to squash history before sending the last patch, is it not how
you do it? Would you like me to re-send the patch with typo corrected?
If no other reviewer finds an issue, then this could be done while
merging. In your place I would wait for now.
Cheers,
Claudius
-Dmitri
On Thursday, February 1, 2018 at 8:41:41 AM UTC-5, Claudius Heine wrote:
Hi Dimitri,
please version your patches.
On 02/01/2018 02:24 PM, [email protected] <javascript:> wrote:
From: Dmitri Toubelis <[email protected] <javascript:>>
This patch allows booting an image without arming watchdog timer
whwn "watchdog=0" parameter is passed to the to the module.
Typo, as Jan already pointed out in previous patch.
Otherwise looks got from my POV.
Thanks,
Claudius
This covers the use case when availability of a hardware driver is
unknown ahead of time and can only be established upon first boot.
The code that runs on the first boot can then identify if supported
hardware watchdog is available and the required driver is present
in the kernel and either update boot configuration re-arming the
timer or issuing a warning unsupported hardware. This also allows
for booting images in virtual environments.
Allow "watchdog" be equal "0"
Move bypass switch to efi_main
Signed-off-by: Dmitri Toubelis <[email protected]
<javascript:>>
---
main.c | 11 ++++++++---
tools/bg_setenv.c | 2 +-
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/main.c b/main.c
index b71f811..64d93b8 100644
--- a/main.c
+++ b/main.c
@@ -157,9 +157,14 @@ EFI_STATUS efi_main(EFI_HANDLE image_handle,
EFI_SYSTEM_TABLE *system_table)
EFI_OUT_OF_RESOURCES);
}
- status = scan_devices(loaded_image, bg_loader_params.timeout);
- if (EFI_ERROR(status)) {
- error_exit(L"Could not probe watchdog.", status);
+ if (bg_loader_params.timeout == 0) {
+ Print(L"Watchdog is disabled.\n");
+ return EFI_SUCCESS;
+ } else {
+ status = scan_devices(loaded_image,
bg_loader_params.timeout);
+ if (EFI_ERROR(status)) {
+ error_exit(L"Could not probe watchdog.",
status);
+ }
}
/* Load and start image */
diff --git a/tools/bg_setenv.c b/tools/bg_setenv.c
index b397aca..37f50ce 100644
--- a/tools/bg_setenv.c
+++ b/tools/bg_setenv.c
@@ -338,7 +338,7 @@ static error_t parse_opt(int key, char *arg, struct
argp_state *state)
break;
case 'w':
i = parse_int(arg);
- if (errno || i == 0) {
+ if (errno || i < 0) {
fprintf(stderr,
"Invalid watchdog timeout
specified.\n");
return 1;
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: [email protected]
<javascript:>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: [email protected]
--
You received this message because you are subscribed to the Google Groups "EFI Boot
Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/efibootguard-dev/10509e29-a2df-4169-8773-e9df6d5f11d8%40siemens.com.
For more options, visit https://groups.google.com/d/optout.
