On 08.01.21 21:20, [ext] [ext] Christian Storm wrote: > Hi Jan, > >>> __builtin_unreachable() is available since gcc 4.5, released 2010. >>> __attribute__((noreturn)) is avilable since gcc 2.5.0, released 1993. >>> __attribute__((unused)) is available since gcc 2.7, released 1995. >> >> It's probably also worth noting that removing the "#if >> defined(__GNUC__)" special case fine because we depend on gnuefi anyway >> - right? > > Well, GNU EFI does actually support a lot of compilers. The interesting > part is in GNU EFI's inc/x86_64/efibind.h:26 (and in the Makefile.defaults > as well), e.g., > > #if defined(GNU_EFI_USE_MS_ABI) > #if (defined(__GNUC__) && (__GNUC__ > 4 || (__GNUC__ == 4 && > __GNUC_MINOR__ >= 7)))||(defined(__clang__) && (__clang_major__ > 3 || > (__clang_major__ == 3 && __clang_minor__ >= 2))) > #define HAVE_USE_MS_ABI 1 > #else > #error Compiler is too old for GNU_EFI_USE_MS_ABI > #endif > #endif > > since you do want to have MS_ABI support. So, reasonable compilers do > support the attributes such that the #else case can simply be dropped > and by this the whole construct. >
In any case, please leave a reasoning for the cut-off case in the commit log. Thanks, Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/2c201be2-bed4-79a7-c09a-270048f72ce2%40siemens.com.
