On 12.11.21 14:52, Michael Adler wrote:
>> These rules could be consolidated with a macro and, at that chance, also
>> slienced ("GEN ...") at that chance.
>
> Hm, I'm not sure I completely understand what you mean. I have tried to make
> it a little more readable by using a SHTAB
> variable and I have added auto-detection for Python to configure.ac. I'm not
> that experienced with autoconf & friends,
> so in case you had something different in mind, could you point me to an
> example?
>
See e.g.
https://github.com/siemens/efibootguard/commit/47d1194adad0c9ed98baacecdc4fb35a56f8ff41.
But that suppressed the output completely. Maybe something for the
mkdir. For shtab invocation, we rather want AM_V_GEN.
In addition, you can try to parameterize the two command further so that
you don't need to spell them out. Also to avoid bugs like forgetting
"-u" in the bg_printenv.bash command...
>> Spurious newline at EOF (2 more times below as well).
>
> Ah ok, then I misunderstood your review comment. I thought you wanted to have
> newlines. I have removed them in patch v5.
>
My comment was misleading, and it was wrong (that hunk was a symbolic
link, not real file).
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
--
You received this message because you are subscribed to the Google Groups "EFI
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/efibootguard-dev/1a786196-de71-5994-5da0-8632f9db23f8%40siemens.com.
