On 15.08.23 17:36, 'Earl Chew' via EFI Boot Guard wrote: > Jan, > >>> The check against configure.ac is to ensure that the MD5 checksum >>> computed against ENV_MEM_USERVARS=131072 is plausibly valid. >> >> Ok, now I see. But then why not use the defaultsize from configure.ac as >> targetsize? > > Hmm ... yes, that's possible. The main downside that I see is that > the golden MD5 checksums are tied to not only the content, but also > the size of the uservars area. > > I thought having the 131072 specified explicitly in the helps make that > relationship more obvious. > > What would you prefer?
OK, a larger default size would require to re-calculate the CRC to that. That will indeed make things even more complicated. Then let's keep things as you suggested. > >> Makes sense now. I'm fine with extracting from config.h, but please >> provide a hint if that file is not found, rather than likely exploding. > > All right. > > So you mean, provide a hint, and fail that step of the test, right? Yes. To my understanding, we will get a weird behaviour right now if config.h is not found. Jan -- Siemens AG, Technology Linux Expert Center -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/7bd8e8c2-fe88-4431-88ba-b8f627e4923c%40siemens.com.
