On 16.08.23 14:45, 'Michael Adler' via EFI Boot Guard wrote: > The initial patch was reverted due to coverity warnings regarding division by > zero. Investigations showed these warnings to be false-positives specific to > Linux kernel code. I've added test cases to demonstrate the false-positive > nature of these warnings. >
Yeah, coverity is not perfect. It also considered bgenv_validate_uservars() incorrect as it would scan for a terminating null in potentially unterminated input, but it missed the size check of that function. Jan > Michael Adler (1): > fix: correctly calculate FAT bit size based on cluster count > > .gitignore | 1 + > Makefile.am | 3 +- > tools/ebgpart.c | 62 ++++++-------- > tools/fat.c | 184 ++++++++++++++++++++++++++++++++++++++++ > tools/fat.h | 25 ++++++ > tools/linux_util.h | 59 +++++++++++++ > tools/tests/Makefile.am | 10 ++- > tools/tests/test_fat.c | 85 +++++++++++++++++++ > 8 files changed, 389 insertions(+), 40 deletions(-) > create mode 100644 tools/fat.c > create mode 100644 tools/fat.h > create mode 100644 tools/linux_util.h > create mode 100644 tools/tests/test_fat.c > -- Siemens AG, Technology Linux Expert Center -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/a205414d-50e3-4517-9b52-b6661c3c897d%40siemens.com.
