On 12.02.24 16:27, 'Earl Chew' via EFI Boot Guard wrote:
> On 2024-02-12 00:17, Jan Kiszka wrote:
>> On 06.02.24 16:47, 'Earl Chew' via EFI Boot Guard wrote:
>>> make check -j $(nproc)
>>> + make check-valgrind -j $(nproc)
>>
>> This target is not generated in my setup. Configure reports
>>
>> ..
>> checking for valgrind... valgrind
>> checking for Valgrind tool memcheck... yes
>> ..
>>
>> What am I missing?
>
> I confirmed that this passes on github.com:
>
> https://github.com/earlchew/efibootguard/actions/runs/7787040735/workflow#L127
>
> Apart from checking the versions of autoconf-archive,
> autoconf, etc, the other part I found important is:
>
> diff --git a/Makefile.am b/Makefile.am
> index 3b05e7c..68c0f59 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -15,7 +15,7 @@
> # Copyright (C) 2013 Karel Zak <k...@redhat.com>
> #
>
> -ACLOCAL_AMFLAGS = -I m4 ${ACLOCAL_FLAGS}
> +ACLOCAL_AMFLAGS = -I m4 --install ${ACLOCAL_FLAGS}
> AM_MAKEFLAGS = --no-print-directory
>
> efibootguarddir = $(libdir)/efibootguard
>
Simpler: Forgot to run autoreconf locally.
But check-valgrind is missing some deps:
Making check-valgrind in tools/tests
USE memcheck:
CC test_bgenv_init_retval-test_bgenv_init_retval.o
CC test_bgenv_init_retval-test_main.o
CC ../../env/env_api.o
CC ../../env/env_api_fat.o
CC ../../env/env_api_crc32.o
CC ../../tools/ebgpart.o
CC ../../env/env_config_file.o
CC ../../env/env_config_partitions.o
CC ../../env/env_disk_utils.o
CC ../../env/uservars.o
CC ../../tools/bg_envtools.o
../../../tools/tests/../../tools/bg_envtools.c:18:10: fatal error:
version.h: No such file or directory
#include "version.h"
^~~~~~~~~~~
compilation terminated.
Jan
--
Siemens AG, Technology
Linux Expert Center
--
You received this message because you are subscribed to the Google Groups "EFI
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to efibootguard-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/efibootguard-dev/45c987b3-f905-45de-aa36-6e2efb483e33%40siemens.com.
