On 19.04.24 14:24, 'Mathieu Alexandre-Tetreault' via EFI Boot Guard wrote:
>>> enum iTCO_versions {
>>> @@ -92,7 +93,12 @@ static const iTCO_regs iTCO_version_regs[] = {
>>> },
>>> [ITCO_V4] =
>>> {
>>> - /* Not implemented yet */
>>> + .pmc_base_reg = 0x10,
>>> + .pmc_reg = 0x1008,
>>> + .pmc_no_reboot_mask = (1 << 4),
>>
>> Is that correct? I'm comparing things here to
>> linux/drivers/watchdog/iTCO_wdt.c, no_reboot_bit() which seems to deliver a
>> mask, not a bit number.
> (1<<4) should be equivalent to 0x00000010. However, it seems that you are
> right the value seems to be wrong. The linux kernel uses 0x00000002(1<<1) for
> iTCO v4.
>
> I'll get the device and do additional tests.
> Do you have some test that you'd like me to do to confirm?
>
Well, the test is simple: Check that the watchdog is firing after the
configured time, rebooting the system. To enforce that, you could load a
Linux kernel that does not contain an iTCO watchdog driver.
Jan
--
Siemens AG, Technology
Linux Expert Center
--
You received this message because you are subscribed to the Google Groups "EFI
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to efibootguard-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/efibootguard-dev/d9e01bb3-0472-4b41-a562-4a4e7b5ffb41%40siemens.com.
