On 16.05.24 12:13, Sjoerd Simons wrote: > Hey, > > On Thu, 2024-05-16 at 12:00 +0200, Jan Kiszka wrote: >> On 16.05.24 11:52, 'Sjoerd Simons' via EFI Boot Guard wrote: >>> This adds support for Tiger lake LP, Jasper lake, Alder lake >>> (various >>> variants), Raptor lake, Meteor lake (various variants) and Birch >>> Stream devices using the relevant pci-ids and chip namings from the >>> linux kernel. >>> >>> Tested on Dell Optiplex 7000 and Optiplex E4 with Alder Lake-S >>> chipsets. >>> >> >> Thanks for the contribution! Just one concern: As we are not using >> the >> exact same enabling logic in EBG compared to the kernel, I'm always a >> bit reluctant to merge support for devices that were not tried in >> real >> life. So, we have 2 of the 10 additions actually tested, right? Can >> you >> explain why the other 8 are a "safe bet"? Or can we extend the on- >> device >> test coverage? > > As they're all itco v6 watchdogs you'd hope it's a pretty safe bet, > assuming the EBG code does reasonable things. The kernel for sure > doesn't further differentiate between different instances/generations. > > I'm happy to limit the patch to just chipsets/generations we've tested > on though if that's the preference. It just makes efibootguard a bit > more cumbersome to adopt for new hardware >
Looking at the much simpler specifics of v6 iTCO again, I agree that these extension are low risk. Thanks, applied. Jan -- Siemens AG, Technology Linux Expert Center -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to efibootguard-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/e99e40cc-9410-4c69-bd4e-00e38d6d953a%40siemens.com.
