On 26/08/2019 16.18, David Tellenbach wrote:
Hi,
Actually, current PRs also have the problem that they are not usable, if the
requester (accidentally) removes (or overwrites) the fork repository.
Yes this seems to be the exact same issue: PRs not based on diffs but on forks.
Something almost all providers do. I never liked that PRs are mainly a provider
and not a VCS feature.
And maybe having existing PRs imported to any form of new PR-management should
not need to be the top-priority. If we have a much better mechanism for PRs on
any future host, than just some kind of (more or less) static image of previous
PRs could be good enough (especially, if the new mechanism does not have an
easy way to import existing PRs -- which could be difficult since the new host
won't have all users registered which ever took part at our current PRs).
If this is enough we can easily work something out (regarding PRs):
- Diffs for a PR:
https://api.bitbucket.org/2.0/repositories/eigen/eigen/pullrequests/{PR-id}/diff
<https://api.bitbucket.org/2.0/repositories/eigen/eigen/pullrequests/%7BPR-id%7D/diff>
- Comments on a PR:
https://api.bitbucket.org/2.0/repositories/eigen/eigen/pullrequests/{PR-id}/comments
<https://api.bitbucket.org/2.0/repositories/eigen/eigen/pullrequests/%7BPR-id%7D/comments>
This looks promising and in my eyes sufficient if we don't get anything
better. If our new host would allow to forward "#N" inside commit
messages to an archive as long as N<threshold, and start enumerating new
PRs starting at that threshold, it would be even greater :)
Of course, we also need a place where we actually store the old PRs. And
decide how we transit from the old to the new PRs.
Cheers,
Christoph
--
Dr.-Ing. Christoph Hertzberg
Besuchsadresse der Nebengeschäftsstelle:
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Straße 5
28359 Bremen, Germany
Postadresse der Hauptgeschäftsstelle Standort Bremen:
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Straße 1
28359 Bremen, Germany
Tel.: +49 421 178 45-4021
Zentrale: +49 421 178 45-0
E-Mail: [email protected]
Weitere Informationen: http://www.dfki.de/robotik
-------------------------------------------------------------
Deutsches Forschungszentrum für Künstliche Intelligenz GmbH
Trippstadter Strasse 122, D-67663 Kaiserslautern, Germany
Geschäftsführung:
Prof. Dr. Jana Koehler (Vorsitzende)
Dr. Walter Olthoff
Vorsitzender des Aufsichtsrats:
Prof. Dr. h.c. Hans A. Aukes
Amtsgericht Kaiserslautern, HRB 2313
-------------------------------------------------------------
