Hi Jens, Without being able to give a definitive answer let me try to address some of your points:
> a) Do you want the same level of coverage as for the already implemented > solvers or more? Are you talking about test coverage here? If yes you should probably try to match the coverage of existing solvers. Keep in mind that some tests exist to cover bugs fixed after the solvers got developed. > b) Would they typically go into the unsupported branch first? First of all the dev branch contains supported and unsupported modules. They are just separated by the directory structure. If your patch extends supported parts of Eigen and if it fits the existing structure it would usually be merged into the supported part (ofc after reviewing it). However, if your patch extends an unsupported module (e.g. BlockSparseMatrix) it would probably be merged into the unsupported part. > c) Where should we discuss this? Should we create an issue/PR on Gitlab/the > mailing list? If you have general design questions the mailing list would be the appropriate place to discuss. If you have a ready or mostly ready implementation a Gitlab PR is the way to go. > Additionally as a future project we want to work on BlockSparse Matrices. > Eigen has some sort of implementation of it in > https://eigen.tuxfamily.org/dox/unsupported/classEigen_1_1BlockSparseMatrix.html > > <https://eigen.tuxfamily.org/dox/unsupported/classEigen_1_1BlockSparseMatrix.html> > Do you know of other people working on this and do you have any information > on the implementation in the link? Unfortunately I cannot give an answer here but I'm sure somebody will soon. Cheers, David > > On 4. May 2020, at 09:23, Jens Wehner <[email protected]> wrote: > > Hello, > > anyone home? I posted this two weeks ago. > > " > Hello Eigen-Developers, > > We have been using Eigen for years now and we are very happy with the > package. > > In the last year we have implemented two more linear solvers,BiGStab(l) and > IDRstab, we would like to add them to Eigen. > > We are unsure about a couple of things: > > a) Do you want the same level of coverage as for the already implemented > solvers or more? > > b) Would they typically go into the unsupported branch first? > > c) Where should we discuss this? Should we create an issue/PR on Gitlab/the > mailing list? > > Additionally as a future project we want to work on BlockSparse Matrices. > Eigen has some sort of implementation of it in > https://eigen.tuxfamily.org/dox/unsupported/classEigen_1_1BlockSparseMatrix.html > > <https://eigen.tuxfamily.org/dox/unsupported/classEigen_1_1BlockSparseMatrix.html> > Do you know of other people working on this and do you have any information > on the implementation in the link? > > Greetings > > Jens Wehner > > | Jens Wehner, PhD | eScience Research Engineer | Email: > [email protected] > <https://outlook.office.com/mail/options/mail/[email protected]> | > Tel: +31(0)6 20 367 166 | > | Netherlands eScience Center <https://www.esciencecenter.nl/> | Science Park > 140 | 1098 XG Amsterdam | The Netherlands | > | Twitter <https://twitter.com/eScienceCenter> | LinkedIn > <https://www.linkedin.com/company/netherlands-escience-center> | Facebook > <https://www.facebook.com/NLeScienceCenter/> | YouTube > <https://www.youtube.com/channel/UCYLAIMi62d8tx3Ru6DOSPeg> | Newsletter > <https://esciencecenter.us8.list-manage.com/subscribe/post?u=a0a563ca342f1949246a9f92f&id=31bfc2303d> > | > > > From: Jens Wehner > Sent: Friday, April 17, 2020 11:55 > To: [email protected] <[email protected]> > Subject: Implementation/Integration of new linear solvers > > Hello Eigen-Developers, > > We have been using Eigen for years now and we are very happy with the > package. > > In the last year we have implemented two more linear solvers,BiGStab(l) and > IDRstab, we would like to add them to Eigen. > > We are unsure about a couple of things: > > a) Do you want the same level of coverage as for the already implemented > solvers or more? > > b) Would they typically go into the unsupported branch first? > > c) Where should we discuss this? Should we create an issue/PR on Gitlab/the > mailing list? > > Additionally as a future project we want to work on BlockSparse Matrices. > Eigen has some sort of implementation of it in > https://eigen.tuxfamily.org/dox/unsupported/classEigen_1_1BlockSparseMatrix.html > > <https://eigen.tuxfamily.org/dox/unsupported/classEigen_1_1BlockSparseMatrix.html> > Do you know of other people working on this and do you have any information > on the implementation in the link? > > Have a nice weekend and thanks for all your work > > Jens Wehner > > | Jens Wehner, PhD | eScience Research Engineer | Email: > [email protected] > <https://outlook.office.com/mail/options/mail/[email protected]> | > Tel: +31(0)6 20 367 166 | > | Netherlands eScience Center <https://www.esciencecenter.nl/> | Science Park > 140 | 1098 XG Amsterdam | The Netherlands | > | Twitter <https://twitter.com/eScienceCenter> | LinkedIn > <https://www.linkedin.com/company/netherlands-escience-center> | Facebook > <https://www.facebook.com/NLeScienceCenter/> | YouTube > <https://www.youtube.com/channel/UCYLAIMi62d8tx3Ru6DOSPeg> | Newsletter > <https://esciencecenter.us8.list-manage.com/subscribe/post?u=a0a563ca342f1949246a9f92f&id=31bfc2303d> > |
