Le dimanche 04 janvier 2009 à 14:07 +0100, Damien Sandras a écrit : > Hi, > > Le samedi 03 janvier 2009 à 19:54 +0100, Eugen Dedu a écrit : > > [...] > > > Here are the issues I found when comparing the svn version with the > > tarball generated: > > > > - present in svn but not present in the tar.gz: directory doc. > > Shouldn't it be added to the tarball? > > I fixed this. > > > - the tar.gz contain the files: ekiga.desktop.in, ekiga.desktop.in.in, > > ekiga.schemas.in.in; I am not sure about the role of these files (given > > that the same files without .in exist), I would like to remove them from > > the tarball, could you confirm that they should be removed? > > I improved this. You only need the .in.in and the generated file. > The reason is that : > - the .in.in is the source, so it should be shipped > - the ekiga.desktop/ekiga.schemas files are generated, but not when > running configure, so you need to ship them (I think) > > > - should Makefile.am too be distributed in the tar.gz given that > > Makefile.in are already distributed? > > Makefile.am is the source, so it should be shipped. > Makefile.in is generated by automake, which is not run when compiling a > release tarball, so it should be shipped > Makefile is generated from Makefile.in, so it should not be shipped (and > it is not) > > > - several files from lib/engine/components/resource-list are not > > included in the tarball, is it normal? > > Only in ekiga-svn/lib/engine/components/resource-list: rl-entry.cpp > > Only in ekiga-svn/lib/engine/components/resource-list: rl-entry.h > > Only in ekiga-svn/lib/engine/components/resource-list: rl-entry-ref.cpp > > Only in ekiga-svn/lib/engine/components/resource-list: rl-entry-ref.h > > Only in ekiga-svn/lib/engine/components/resource-list: rl-list.cpp > > Only in ekiga-svn/lib/engine/components/resource-list: rl-list.h > > - lib/engine/gui/kde-core is not in the distribution either, is it > > normal? <-- Julien ? > > That is because when you ran autogen, you did not enable those modules. > If you do, they will be included in the make dist. However, it is not > 100% necessary because it is experimental code. > > > - lib/engine/include in svn is empty, remove it or do you prefer to keep it? > > I removed it. > > > - the tarball does not contain the following files, which are found in > > svn: win32/diff/ptlib_ptlib.pc.in file, and win32/directx directory. I > > propose to include them in the tarball, what do you think? > > I fixed it. > > Thanks for your work!
PS: Plz tell me when you want the tag to be done. -- _ Damien Sandras (o- //\ Ekiga Softphone : http://www.ekiga.org/ v_/_ Be IP : http://www.beip.be/ FOSDEM : http://www.fosdem.org/ SIP Phone : sip:[email protected] _______________________________________________ Ekiga-devel-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/ekiga-devel-list
