> --- a/tests/ChangeLog
> +++ b/tests/ChangeLog
> @@ -1,5 +1,11 @@
>  2012-08-16  Mark Wielaard  <[email protected]>
>  
> +     * run-readelf-unknown-self.sh: New test.
> +     * Makefile.am (TESTS): Add run-readelf-unknown-self.sh.
> +     (EXTRA_DIST): Likewise.
> +
> +2012-08-16  Mark Wielaard  <[email protected]>
> +
>       * allregs.c (dwarf_encoding_string): Removed.
>       * show-die-info.c (dwarf_tag_string): Removed.
>       (dwarf_attr_string): Removed.

No redundant header lines when the previous top change has the same header.

> +# Make sure there are no unknown DWARF codes.
> +testrun_on_self_nomatch "\?\?\? \([x0-9]+\)|lo_user\+0x[0-9a-f]+" 
> ../src/readelf -N -w

This is still "" and should be ''.

> +  for file in $self_test_files; do
> +    testrun "$@" $file > self_matches.in

This should fail the test if testrun (i.e. readelf) exits nonzero.

> +      exit_status=1;

Still superfluous ; here.

Did you resend the old version of the patch instead of a new one?


Thanks,
Roland
_______________________________________________
elfutils-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/elfutils-devel

Reply via email to