> +    /* Can't happen */

Period and two spaces at the end of a sentence.

> +    default:
> +        *setname = NULL;
> +        return 0;

Bad indentation.

> --- a/libebl/ChangeLog
> +++ b/libebl/ChangeLog
> @@ -1,3 +1,8 @@
> +2012-08-21  Jeff Kenton  <[email protected]>
> +
> +     * eblopenbackend.c (machines): Add tilegx.
> +
> +
>  2011-06-26  Mark Wielaard  <[email protected]>

One excess blank line there.

> --- a/src/ChangeLog
> +++ b/src/ChangeLog
> @@ -1,3 +1,8 @@
> +2012-08-21  Jeff Kenton  <[email protected]>
> +
> +     * elflint.c (valid_e_machine): Add EM_TILEGX and EM_TILEPRO.
> +
> +
>  2012-08-16  Mark Wielaard  <[email protected]>

Same here.


Looks fine to me other than those nits.


Thanks,
Roland
_______________________________________________
elfutils-devel mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/elfutils-devel

Reply via email to