I'd put the SHDR parameter first. That's more consistent with how we've chosen the signatures of other hooks.
I'm inclined toward the suggestion I just made in another message, to make a NULL value for NAME valid by updating the existing implementations. In that case, the strip.c change: - if (! tname || ! ebl_debugscn_p (ebl, tname)) + if (! tname || ! ebl_debugscn_p (ebl, tname, tshdr)) should be: - if (! tname || ! ebl_debugscn_p (ebl, tname)) + if (! ebl_debugscn_p (ebl, tshdr, tname)) so it's up to the backend hook how to respond when the name isn't available. (Not that this scenario really matters, as it indicates a bogus ELF file.) There are some style issues with your ChangeLog entries and some lines you've made too long (all lines should be < 80 columns). Mark can help you get all those nits right. (I'll be on vacation after today.) Thanks, Roland _______________________________________________ elfutils-devel mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/elfutils-devel
