On Thu, 2012-11-29 at 10:36 +0100, Jan Kratochvil wrote: > commit 3a9fe450996371575f93d3790171b5dc27856f6b > Author: Jan Kratochvil <[email protected]> > Date: Thu Oct 18 00:11:30 2012 +0200 > > libdwfl/ > * argp-std.c (offline_find_elf): New function. > (offline_callbacks): Use it for FIND_ELF. > (struct parse_opt): New. > (parse_opt): New KEY ARGP_KEY_INIT. In other make HOOK struct > parse_opt pointer from former Dwfl pointer. Delay 'e and OPT_COREFILE > processing till ARGP_KEY_SUCCESS. Initialize state->INPUT already from > ARGP_KEY_SUCCESS. Modify the cleanup in ARGP_KEY_ERROR. Make the > final state->INPUT initialization optional. > * dwfl_end.c (dwfl_end): Free EXECUTABLE_FOR_CORE. > * libdwflP.h (struct Dwfl): New field executable_for_core. > > tests/ > * run-addrname-test.sh: New test for PIE relocation. > * testfile70.core.bz2: New file. > * testfile70.exec.bz2: New file. > * Makefile.am (EXTRA_DIST): Add testfile70.core.bz2 and > testfile70.exec.bz2 . > > Signed-off-by: Jan Kratochvil <[email protected]>
Looks good to me. With two tiny nits: - The all-caps FIND_ELF, INPUT and EXECUTABLE_FOR_CORE in the commit message and ChangeLog entry. - You forgot to update the copyright year in argp-std.c. Thanks, Mark _______________________________________________ elfutils-devel mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/elfutils-devel
