On Thu, 2013-02-28 at 15:30 +0100, Jan Kratochvil wrote: > [patchv3] Fix dwfl_report_elf BASE alignment > https://lists.fedorahosted.org/pipermail/elfutils-devel/2012-November/002759.html > Message-ID: <[email protected]>
I think we agree the actual change is fine. Roland reviewed your glibc comment change to l_addr in link.h. So I assume he didn't see anything odd either in this change. The only reason I was hesitant about the patch was the testcase. I assume this mimics what dwfl_linux_proc_report () would do, and it was easier to write it using dwfl_report_elf ()? If you could add a comment where the constants for base (0x7f3560c92000) and funcaddr (0x7f3560c92585) come from (and/or how to calculate your own in case someone wants to extend the testcase) that would be appreciated. Thanks, Mark _______________________________________________ elfutils-devel mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/elfutils-devel
