On 04/10/2014 08:16 PM, Mark Wielaard wrote:
On Thu, 2014-04-10 at 13:08 +0200, Florian Weimer wrote:
+ * libdw.h (enum Dwarf_Cmd): New member
+ DWARF_C_FLAG_NO_DEBUGALTLINK.
+ * libdwP.h (DWARF_C_FLAG_MASK): New macro.
+ * dwarf_begin_elf.c (check_section): Move call to to
+ open_debugaltlink to ...
+ (dwarf_begin_elf): here. Mask command flags and handle
+ DWARF_C_FLAG_NO_DEBUGALTLINK.
+ * dwarf_begin.c (dwarf_begin): Mask command flags.
I don't really like this. This assumes we keep the magic opening of the
altfile in dw. But I think we should just drop it eventually
Yes, but that's not really backwards-compatible. Even the test suite
breaks.
> and move any magic to the dwfl side. When we provide dwarf_setalt()
then users
should just explicitly always use that IMHO.
I have a patch for that as well, but I couldn't find a way to emulate
the old dwarf_begin behavior using dwfl in the tests/allfcts.c test
case. Pointers to documentation or example code much appreciated. :-)
Your dwarf_setalt comments make sense.
--
Florian Weimer / Red Hat Product Security Team
