On 04/15/2014 02:34 PM, Mark Wielaard wrote:
On Mon, 2014-04-14 at 11:12 +0200, Florian Weimer wrote:
---
  .gitignore | 99 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 99 insertions(+)

Hmmm. This is all for building with srcdir == builddir isn't it?

Indeed.

I really don't like that. IMHO we should advise people to always build
with srcdir != buildir.

Oh, it's a valid position. But based on the .gitignore file, that wasn't obvious to me at all because it covers *some* of the generated files, but not all of them. I'll propose a cleanup in the other direction, removing unnecessary entries that are not needed with srcdir != builddir, and adding a comment that you should build in a separate directory.

--
Florian Weimer / Red Hat Product Security Team

Reply via email to