On 13 May 2015 16:18, Mark Wielaard wrote: > On Thu, 2015-05-07 at 22:08 -0400, Mike Frysinger wrote: > > > If there are specific hacks you would like to see brought over from the > > > portable branch to master, please do propose and we can discuss them. > > > But I really think none of them are needed or should be used these days. > > > > there's still the issue of --disable-werror > > I believe we discussed before, but could you remind me why it is > necessary for newer GCC versions? > > If there are any warnings that are turned into errors we should really > just fix them. Do you have any specific examples? > > What does the configure option add over just using CFLAGS=-Wno-error?
because you guys (reasonably) cannot test every gcc/C library version/flags/arch combination. focusing on newer versions makes sense, but not all distros are always running the latest. i also agree that having it default to on is ok and some distros which have tight control over everything (like fedora) will set it to on. but i think that should be left to the distro to control. in practice, we already are either by `sed` or patching in the werror configure flag. keep in mind that not all warnings are even correct -- gcc has false positives from time to time. trying to track how to squelch those across multiple gcc versions is a waste of time. i don't have specific examples readily available ... we noticed in Gentoo when users report via irc (which has no logs). i know some more extensive flags like lto and inline can often trigger unresolvable warnings about functions not being inlined. -mike
signature.asc
Description: Digital signature
