Mark, Thank you very much for pushing those fixes. I have attached the remaining changes in the attached 2 files.
On Wed, Sep 9, 2015 at 4:32 AM, Mark Wielaard <[email protected]> wrote: > On Tue, 2015-09-08 at 15:14 -0700, Chih-hung Hsieh wrote: > > The 4 split patches looked good to me. > > Thanks. I pushed them to master. > > > Yes, the labs should be llabs to work on 32-bit systems. > > OK, I also pushed the attached to fix that. > > > About removing the NULL tests of parameters declared with NN, > > I don't mind removing them. I was extra careful not to remove > > any check in case some code could call those functions with > > NULL parameter and without the NN declaration. > > > > Please let me know if you need me to prepare another patch > > to remove those unnecessary NULL tests > > Yes, that would be nice. Lets fix this properly by making sure the > nonnull annotations are correct and to not do any unnecessary NULL > checks in that case. > > Thanks, > > Mark >
0001-Remove-redundant-NULL-tests.patch
Description: Binary data
0001-Initialize-variable-before-use.patch
Description: Binary data
