Okay, it is easy for me to resend the patch through git send-email. For the moved code, it would be difficult to review without some smart diff tool. For in-place replacement of nested functions to macros, the diff is actually easier to verify.
If the original intention is to inline those nested functions, I think macros should be fine. I don't mind moving them to file scope static functions either, if the performance difference of not-inlining and passing extra arguments is not important. On Fri, Sep 11, 2015 at 3:41 PM, Roland McGrath <[email protected]> wrote: > Macros are the last resort. When they can be file-scope static functions > without a huge pain in the ass, always do that instead. I think we need to > take these case by case, rather than trying to review one giant patch. > Also, attachments suck and you'll get far quicker review if you avoid them. >
