Hi Mark, On Mon, May 2, 2016 at 12:51 PM, Mark Wielaard <[email protected]> wrote: > Thanks. Looks correct. I added a ChangeLog entry and pushed this.
Thanks Mark! > (One of these days we'll have to think of an alternative for ChangeLogs.) It would be nice to generate those from `git log` somehow... I know dejagnu actually requires that the git log message is ChangeLog formatted but that looks awful from a git perspective :-) > Note that in general passing -Werror should not be necessary because > the build should add -Werror where necessary to catch any new warnings > early. Some extra -Werror is always nice of course (although you might > want to watch for where the build uses no_Werror = yes, currently only > ldlex because it is a generated file). Ok, so it turns out the other problem I'm running into is that detection of supported compiler warnings is not done with -Werror, so configure thinks they're supported while in fact they're not, and later on when the build is done with -Werror (for most targets) they start failing since the options are unsupported... I have a follow up fix, will send you another patch shortly. This time with ChangeLog :-) Cheers! Filipe
