Hi -

> 1. Remove needless profile=@profile@

You mean "prefix=@prefix@".  And it's not needless,
because @sysconfdir@ often expands to "$prefix/something",
which requires a prefix var to be set for evaluation.

> 2. Simplify needless sh -c "cat glob 2>/dev/null"
>    into cat glob 2>/dev/null

This is not needless, but I forget the exact details.  It probably has
to do with the $prefix expansion just above, or perhaps glob
non-matching error handling.

> 3. Use $( instead of ` under sh

I'm neutral on this, assuming it's not a bashism.

> 4. Assign to D_U directly and either export it or unset it

I'm neutral on this.


- FChE

Reply via email to