Re: [PATCH] libelf: Get orig_addralign the same way for 32/64 bit ELF in elf_compress

[Mark Wielaard]

Hi Aaron,

On Tue, 2026-05-19 at 18:08 -0400, Aaron Merey wrote:
> On Mon, May 18, 2026 at 12:54 PM Mark Wielaard <m...@klomp.org> wrote:
> > 
> > Depending on whether the ELF was 32 or 64 bit elf_compress would get
> > the original sh_addralign, as embedded in the Chdr, differenly. For
> > 32bit ELF we would simply get the sh_addralign from the Shdr. For
> > 64bit ELF we would take the (max) alignment of the underlying
> > Elf_Data, provided by __libelf_compress. Use the second method for
> 
> I think this description of the 32bit and 64bit approaches is
> reversed. It looks like the 64bit ELF got sh_addralign from the Shdr.
> Otherwise LGTM.

Thanks. You are right, sharp eyes! I fixed up the commit message and
ChangeLog entry and pushed.

Cheers,

Mark