https://sourceware.org/bugzilla/show_bug.cgi?id=34403
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mark at klomp dot org
Attachment #16847|message/rfc822 |text/plain
mime type| |
Attachment #16847|0 |1
is patch| |
--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
Comment on attachment 16847
--> https://sourceware.org/bugzilla/attachment.cgi?id=16847
Makefile.am patch against elfutils 0.195
This is an interesting find. This code comes from before 2015 when libelf
didn't link with zlib. I think nobody realized that those crc32 functions had
almost the same signature and computed the same thing (we should double check
that though, there are variants of crc32, the one we want is what gdb uses for
.gnu_debuglink).
I think instead of just filtering out this object file from the archive we
should probably rewrite the code to explicitly use the zlib crc32 function
(which probably has an optimized implementation) and completely remove the
crc32.c source from libelf. Or simply put the implementation directly into
libelf/libelf_crc32.c (if the zlib crc32 function != our crc32 one).
--
You are receiving this mail because:
You are on the CC list for the bug.
