On Wed, Aug 12, 2026, at 9:27 PM, Aaron Merey wrote:
>> +
>> +uint32_t
>> +dwflst_arch_expected_frame_nregs (GElf_Half machine)
>> +{
>> + /* For aarch64, we actually use fewer than ebl->frame_nregs to unwind: */
>> + if (machine == EM_AARCH64)
>> + return 14;
>> + if (machine == EM_ARM)
>> + return 16;
>> + /* On x86, expect everything except FLAGS: */
>> + if (machine == EM_X86_64 || machine == EM_386)
>> + /* XXX An external user of the library can't access the Ebl, hence
>> + can't conveniently provide it to us it here. We provide the
>> + constant directly rather than initializing a new Ebl. */
>> + return machine == EM_X86_64 ? 17 : 9;
>> + /* return ebl_frame_nregs(ebl); */
>> + /* XXX Other architectures are not supported yet.
>> + In general, it's fine to be on the permissive side here. */
>> + return 1;
>
> I believe 0 should be returned here instead of 1. libdwfl_stacktrace.h
> comment for this function states that 0 is returned when the arch is
> not supported. LGTM otherwise.
Missed this comment when I did the merge. Oops.
Fixing in commit 4167f80aceb0bff, should be correct now.
