On Fri, Jul 06, 2007 at 03:22:17AM +0300, Kalle Olavi Niemitalo wrote:
> Witold Filipczyk writes:
>
> > On my branch I made that check and other changes to
> > configure.in which significantly speed up builds on old
> > hardware.
>
> What kind of hardware and how many seconds of speedup?
It's old laptop with P75.
Testing all cases for SpiderMonkey took more than 1 minute.
Similar case for Lua.
Internal macros of autoconf, eg. AC_PATH_X check for
header existence first, so IMHO it's the right way.
> My login script sets CPPFLAGS="-I${HOME}/prefix/include" and
> LDFLAGS="-L${HOME}/prefix/${machtype}/lib", and I install SEE and
> FSP in those directories. elinks/configure --help indicates that
> these environment variables can be used for specifying
> nonstandard locations of headers and libraries. Previously, the
> SpiderMonkey check also respected these variables: the second
> iteration of the outer loop has spidermonkeydir="", and that
> value made the script try to use the library without adding any
> -I or -L options. It seems you have now removed this
> possibility, by making the script insist on test -f
> "$spidermonkeydir$spidermonkeyinclude/jsapi.h".
I didn't think of such cases. You could add --with-spidermonkey=DIR.
IMHO this way should be the default instead of adding new directories
to search.
> On the other hand, I do not know whether SpiderMonkey really
> supports being installed and used in that way. The install
> target in xulrunner-1.8.1.4/config/rules.mk does appear to create
> a $(MODULE) subdirectory in $(includedir), and the JavaScript C
> Engine Embedder's Guide talks about including "jsapi.h" and not
> "mozjs/jsapi.h", so perhaps SpiderMonkey expects to always get a
> separate -I option.
>
> I am thus not entirely against such a change. However, if
> spidermonkeydir="" is now intended to mean the root directory
> rather than the default, I think the test ! -z "$spidermonkeydir"
> should then be removed, so that the script always adds the -I and
> -L options.
>
> I have not reviewed the Lua change yet.
_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev
