Jonas Fonseca <[EMAIL PROTECTED]> wrote Tue, Aug 28, 2007:
> Kalle Olavi Niemitalo <[EMAIL PROTECTED]> wrote Tue, Aug 28, 2007:
> > In elinks-0.12/src/protocol/test/stub.c, we now have:
> > 
> > static void
> > die(const char *msg, ...)
> > {
> >     va_list args;
> > 
> >     if (msg) {
> >             va_start(args, msg);
> >             vfprintf(stderr, msg, args);
> >             fputs("\n", stderr);
> >             va_end(args);
> >     }
> > 
> >     exit(!!NULL);
> > }
> > 
> > !!NULL is 0.  Wouldn't it make more sense to exit(1) or
> > exit(EXIT_FAILURE), as an error has occurred?
> 
> Maybe a unified version should even go to a src/util/test.{h,inc} file.

This has now been reworked in elinks-0.12.

-- 
Jonas Fonseca
_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev

Reply via email to